Closed ghost closed 4 years ago
Therefore, I think it needs to fix like Step 2 above, but I wonder if the url was verified as official when first introduced to the cask. Could you tell me how to make sure?
You submit it and a maintainer will verify it. I just did and it seems fine.
When it's confirmed, I will send PR.
If you already have a PR, don’t ask for permission to submit, just do and we’ll discuss it there. It saves time and allows for better discussion.
General troubleshooting steps
--force
.brew update-reset && brew update
and retried my command.brew doctor
, fixed as many issues as possible and retried my command.Description of issue
Latest Zoomus cannot be downloaded.
It is because Zoomus download link now redirects to cloudfront URL, and it adds unnecessary query to URL, so filename under
Caches/Homebrew/downloads
and symlink underCaches/Homebrew/Cask
doesn't match with the nameZoom.pkg
.To fix it, I approach the below steps.
Fix
Homebrew/cask/installer.rb
to ignore query if URL has query. This is big changing so I skipped.Fix
homebrew-cask/Casks/zoomus.rb
url ashttps://d11yldzmag5yn.cloudfront.net/prod/#{version}/Zoom.pkg
. I made a branch and this works fine and passed all test.Therefore, I think it needs to fix like Step 2 above, but I wonder if the url was verified as official when first introduced to the cask. Could you tell me how to make sure?
I checked URLs in old commits, and they all seem to redirect to
d11yldzmag5yn.cloudfront.net
, so fine.When it's confirmed, I will send PR.
Command that failed
Output of command with
--force --verbose --debug
Output of
brew cask doctor
Output of
brew tap