miccal
commented
4 years ago @amharris do you get the same error if you run the command
brew cask install imaging-edge --no-quarantine?
Closed amharris closed 4 years ago
miccal
commented
4 years ago @amharris do you get the same error if you run the command
brew cask install imaging-edge --no-quarantine?
amharris
commented
4 years ago @miccal Unfortunately, yes.
miccal
commented
4 years ago How about if you download and install the pkg manually, does the install succeed?
vitorgalvao
commented
4 years ago I can confirm on a VM this doesn’t work via HBC but does work via a manual install. The failure may be because two licenses that have to be agreed on are show. Two possible ways to go about it. The first one is preferred because it uses features we support.
pkg choices: to accept the licenses.pkg and move the app inside (there’s no pre install script and the post install script seems to be irrelevant for functionality).Also, a license caveat should be added, if there’s a webpage we can link to.
amharris
commented
4 years ago @miccal Yes. Interestingly, I also tried upgrading it (before I had run brew cask zap imaging-edge to try with a clean slate) via MacUpdater and it also experienced issues, even though it launched the pkg installer. It seemed to think there were multiple versioned copies of the app installed on the system but the new one seemed to disappear and the old one was always left in place.
That aside, I can't give much more information, other than trying any suggestions. However, @vitorgalvao being a team member seems to have much more insight.
Any time you need me to test something to try and fix this updated Cask, just give me a shout. 👍
amharris
commented
4 years ago @vitorgalvao It's probably worth noting that before, the Imaging Edge suite comprised of three separate apps installed within an Imaging Edge/ subdirectory within /Applications/.
Having installed the newly-updated package, fresh from the pkg, it appears that it's now stored in the root of /Applications/ and is a unified launcher that requires you to perform another download to install each of the programmes.
That secondary pkg then launches a new install with two licenses to be agreed to in and of itself.
After that's been installed, the older version's structure of /Applications/Imaging Edge/<Each of the three programmes> is set up once again.
vitorgalvao
commented
4 years ago Having to download stuff after the download to be usable makes the cask way less useful. Considering it has so few users, unless someone fixes it, it will be best to just remove it.
amharris
commented
4 years ago @vitorgalvao I'll be honest; I wouldn't disagree. After all, if updates involve a two-part process (that may change in structure once again), it's likely more work than it's worth to keep maintained.
I would say that, in theory, it could be possible to find the endpoint to downloading the RVE_INST.dmg package and using that, as the 'Imaging Edge Desktop' app itself may not strictly be necessary. It seems like extra bulk in my view.
Of course, I'm not the experienced one here in terms of scripting a Cask formula, so don't take my concurrence above as a well-informed agreement or conclusion. However, if Homebrew Cask maintainers deem it to be too troublesome–yeah, get rid of it.
miccal
commented
4 years ago
- Use
pkg choices:to accept the licenses.
There does not appear to be any valid choices for these:
-bash-5.0.17- /Users/miccal (30) [> installer -showChoicesXML -pkg /Users/miccal/Downloads/ied_1_0_02.pkg -target /
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<array>
<dict>
<key>childItems</key>
<array>
<dict>
<key>childItems</key>
<array/>
<key>choiceDescription</key>
<string></string>
<key>choiceIdentifier</key>
<string>installer_choice_1</string>
<key>choiceIsEnabled</key>
<false/>
<key>choiceIsSelected</key>
<integer>1</integer>
<key>choiceIsVisible</key>
<true/>
<key>choiceSizeInKilobytes</key>
<integer>15072</integer>
<key>choiceTitle</key>
<string>Image Data Converter</string>
<key>pathsOfActivePackagesInChoice</key>
<array>
<string>file://localhost/Users/miccal/Downloads/ied_1_0_02.pkg#Imaging_Edge.pkg</string>
</array>
</dict>
</array>
<key>choiceIdentifier</key>
<string>__ROOT_CHOICE_IDENT_DISTRIBUTION_TITLE</string>
<key>choiceIsEnabled</key>
<true/>
<key>choiceIsSelected</key>
<integer>1</integer>
<key>choiceIsVisible</key>
<true/>
<key>choiceSizeInKilobytes</key>
<integer>0</integer>
<key>choiceTitle</key>
<string>Imaging Edge Desktop</string>
<key>pathsOfActivePackagesInChoice</key>
<array/>
</dict>
</array>
</plist>
adidalal
commented
4 years ago @amharris If you're curious:
The direct link to IE_INST.pkg can be grabbed from https://support.d-imaging.sony.co.jp/disoft_DL/imagingedge_DL/mac?fm=dt
That pkg directly installs the 3 apps inside ~/Applications/Imaging Edge, I don't think there's a need for the wrapper app at all in the cask, considering I was able to directly extract and run them.
Also, if you were curious, here is the (Automator) script that Uninstall.app for the "wrapper application" runs:
# Display a simple welcome message first.
#
echo "Welcome to the Imaging Edge Desktop uninstaller script."
appPath="$1"
shift
## Change Working Dir
cd $appPath
## Kill Process
pgrep "Imaging Edge Desktop" | xargs kill -9
## Remove login service
echo "Removing Login Service"
osascript -e 'tell application "System Events" to delete login item "Imaging Edge Desktop"'
## Remove application
## Forget we ever got installed
echo "Removing Imaging Edge Desktop from /Applications/ folder"
echo "Removing installation info"
osascript -e 'do shell script "sudo /bin/rm -r /Applications/Imaging\\ Edge\\ Desktop.app ; sudo /usr/sbin/pkgutil --forget com.sony.ImagingEdgeDesktop.pkg" with administrator privileges'
echo "Done."tl;dr: the wrapper app is bloat, you could change the cask to directly install the main pkg
amharris
commented
4 years ago @adidalal Oh, agreed. I was presenting this particular approach as one option as well—the parent-level app is a bit pointless.
I'd personally be fine with that. Sony just has a habit of changing these things a fair bit; but I suppose if it ever needs to be removed, we can cross that bridge then. For now, perhaps I'll have a go but it'd be my first contribution to a Cask formula, so I'd need to dig into the docs to figure out how to make it work locally, before creating a PR. I don't want to submit guesswork. 🙂
Thanks for providing the script from the wrapper app's uninstall process.
adidalal
commented
4 years ago I just thought it was funny that the wrapper app did nothing, I don't think you need to worry about it at all for the cask, just skip it entirely. That URL should be stable, but, it's Sony, so who knows.
The main pkg should be fairly straightforward. There are a bunch of examples on how to install pkgs, but essentially it's this. Test locally with these directions.
Suspicious Package and AppCleaner may also help:
brew cask install appcleaner suspicious-package
Good luck!
vitorgalvao
commented
4 years ago
General troubleshooting steps
--force.brew update-reset && brew updateand retried my command.brew doctor, fixed as many issues as possible and retried my command.Description of issue
I tried upgrading Sony's Imaging Edge bundle with
brew cu -aand sayingytoimaging-edgebut it failed. I also tried uninstalling withbrew cask zap imaging-edgeand reinstalling but to no avail. Specifically, the version 1.0.02, as recently updated (at the time of writing) in https://github.com/Homebrew/homebrew-cask/commit/2534986b9c711740ec5be5e04575d4ac6917d247.Command that failed
Output of command with
--force --verbose --debugOutput of
brew cask doctorOutput of
brew tap