portable-package: fix building deps as bottles

Homebrew / homebrew-portable-ruby

🚗 Versions of Ruby that can be installed and run from anywhere on the filesystem.

BSD 2-Clause "Simplified" License

133 stars 43 forks source link

portable-package: fix building deps as bottles #105

Closed mistydemeo closed 4 years ago

mistydemeo commented 4 years ago

HOMEBREW_BUILD_BOTTLE was removed.

Fixes #104.

/cc @Bo98

sjackman commented 4 years ago

Just a note for posterity: If none of the dependencies have a postinstall, the simplest solution is to replace brew install -s with brew install --build-bottle. That could be fragile if one of the dependencies later gains a necessary postinstall.

mistydemeo commented 4 years ago

Planning to rebuild tomorrow. Will also investigate Ruby's deps to make sure they're also being built as appropriate - the code implies it's intending to pour bottles for deps, but none exist. That said a 10.10 VM is probably already using an old enough CPU!

mistydemeo commented 4 years ago

Confirmed we should be fine here. Merging now, will rebuild and upload bottles shortly.

sjackman commented 4 years ago

Thank you, Misty! ❤️