Homebrew / homebrew-portable-ruby

🚗 Versions of Ruby that can be installed and run from anywhere on the filesystem.
BSD 2-Clause "Simplified" License
133 stars 43 forks source link

Ruby 3 working branch #177

Closed Bo98 closed 1 year ago

Bo98 commented 1 year ago

Tests for Ruby 3.2.

What I plan for this branch:

Don't really want to faff around with versioned formulae and adjusting all the workflows to build twice when branches work fine for this purpose, are simpler and make the diff easier to follow.

EricFromCanada commented 1 year ago

Off-topic: are .humanize and .titleize in Abstract/portable-formula.rb vestigial remains of an older way of handling macOS version names? They don't seem to be defined anywhere.

Bo98 commented 1 year ago

They were ActiveSupport stuff removed with https://github.com/Homebrew/brew/pull/14778. The code here just never got updated, nor is it a code path CI covers.

I suppose that's a problem shared with all of the ActiveSupport extensions - they're not explicitly a part of our public API but some are highly used regardless in homebrew-core etc.

Bo98 commented 1 year ago

This is probably ready to tag a release on and to add an opt-in within brew.

I could either tag a release as "3.1.4-rc.homebrew1" or just do "3.1.4" and revision bump if it ends up having issues. I don't anticipate any though and will test a bit locally.

SMillerDev commented 1 year ago

Let's keep it in line with the normal versions and do rev bumps if needed

MikeMcQuaid commented 1 year ago

Agreed. Let's version this normally and then can make it HOMEBREW_DEVELOPER only for some Homebrew/brew testing and then get it early on a tag for testing before stable branch folks.

Bo98 commented 1 year ago

HOMEBREW_RUBY3 🔜

(today)