workflows: various cleanups

Homebrew / homebrew-portable-ruby

🚗 Versions of Ruby that can be installed and run from anywhere on the filesystem.

BSD 2-Clause "Simplified" License

128 stars 43 forks source link

workflows: various cleanups #180

Closed Bo98 closed 9 months ago

Bo98 commented 9 months ago

Remove CI on master push. This is a low volume repository so spending an extra 20-25 minutes is a waste of self-hosted resources when we don't allow direct pushes without a pull request. If there's a concern of two simultaneous PRs causing problems only when merged together, we can enable "Require branches to be up to date before merging", which will solve those concerns with minimal annoyance given the PR volume.
Remove run attempt from ephemeral names as we don't need that anymore.
Scope permissions slightly more tightly
Minor cleanup of unused stuff

MikeMcQuaid commented 9 months ago

Remove CI on master push. This is a low volume repository so spending an extra 20-25 minutes is a waste of self-hosted resources when we don't allow direct pushes without a pull request. If there's a concern of two simultaneous PRs causing problems only when merged together, we can enable "Require branches to be up to date before merging", which will solve those concerns with minimal annoyance given the PR volume.

Could we keep brew test-bot --only-tap-syntax running on a Linux runner for the master branch, please?

MikeMcQuaid commented 9 months ago

Otherwise: all agreed, nice work 👍🏻

Bo98 commented 8 months ago

Done in https://github.com/Homebrew/homebrew-portable-ruby/commit/0f7b1d15ef6bec549017612f442ef410664698d4