Homebrew / homebrew-portable-ruby

🚗 Versions of Ruby that can be installed and run from anywhere on the filesystem.
BSD 2-Clause "Simplified" License
128 stars 43 forks source link

Portable Ruby 3.3.1 #190

Closed MikeMcQuaid closed 3 months ago

MikeMcQuaid commented 3 months ago

Maybe we want 3.2 instead but 3.3 seems reasonable for us to at least try out.

Also remove unneeded dependencies.

Closes https://github.com/Homebrew/homebrew-portable-ruby/pull/189

Bo98 commented 3 months ago

libedit and ncurses(?) I think can be deleted entirely if we're definitely going for 3.3.

We should decide what the update strategy here is going forward. Last time the idea was x.(y - 1).z on Aprils. Maybe the strategy now is latest x.y.z when z >= 1.

MikeMcQuaid commented 3 months ago

We should decide what the update strategy here is going forward. Last time the idea was x.(y - 1).z on Aprils. Maybe the strategy now is latest x.y.z when z >= 1.

Yeh, Ruby minor releases are stable enough now that 3.3.1 seems pretty rock solid in my use elsewhere.

I like the idea of x.y.(z >=1) as you've said (and ideally start tracking the patch releases too).

MikeMcQuaid commented 3 months ago

libedit and ncurses(?) I think can be deleted entirely if we're definitely going for 3.3.

Done!

Bo98 commented 3 months ago

I like the idea of x.y.(z >=1) as you've said (and ideally start tracking the patch releases too).

This is nice since I was wanting to add autobump and something like this can be nicely algorithmically picked in a livecheck block.

MikeMcQuaid commented 3 months ago

MJIT_CC I think can be removed too

Good idea, done!

carlocab commented 3 months ago

brew tests is looking good for me with 3.3.1. Only failure seems unrelated:

Failures:

  1) Cask::Artifact::App install_phase when the target already exists given the force option target is user-owned but contains read-only files overwrites the existing app
     Failure/Error: let(:install_phase) { app.install_phase(command:, adopt:, force:) }

     ErrorDuringExecution:
       Failure while executing; `/usr/bin/env touch /private/tmp/homebrew-tests-20240515-52974-mimh8r/cask-appdir/Caffeine.app/.homebrew-write-test` exited with 1. Here's the output:
       touch: /private/tmp/homebrew-tests-20240515-52974-mimh8r/cask-appdir/Caffeine.app/.homebrew-write-test: Permission denied
     # ./system_command.rb:352:in `assert_success!'
     # ./system_command.rb:75:in `run!'
     # ./system_command.rb:40:in `run'
     # ./test/support/helper/cask/never_sudo_system_command.rb:8:in `run'
     # ./system_command.rb:44:in `run!'
     # ./cask/quarantine.rb:236:in `app_management_permissions_granted?'
     # ./cask/artifact/moved.rb:107:in `move'
     # ./cask/artifact/moved.rb:17:in `install_phase'
     # ./test/cask/artifact/app_spec.rb:13:in `block (2 levels) in <top (required)>'
     # ./test/cask/artifact/app_spec.rb:185:in `block (7 levels) in <top (required)>'
     # ./test/cask/artifact/app_spec.rb:185:in `block (6 levels) in <top (required)>'
     # ./test/support/helper/spec/shared_context/homebrew_cask.rb:64:in `block (2 levels) in <top (required)>'
❯ brew config | rg 'Homebrew Ruby'
Homebrew Ruby: 3.3.1 => /Users/carlocab/.rbenv/versions/3.3.1/bin/ruby
MikeMcQuaid commented 3 months ago

Thanks for help @carlocab and @Bo98!