search

Homebrew / homebrew-portable-ruby

🚗 Versions of Ruby that can be installed and run from anywhere on the filesystem.
BSD 2-Clause "Simplified" License
128 stars 43 forks source link

Fix shellcheck issues #217

Closed samford closed 2 months ago

samford commented 2 months ago

shellcheck is reporting SC2086 ("Double quote to prevent globbing and word splitting") issues in the release.yml workflow. This adds quotes around the related areas to resolve the issues.

There's still one remaining actionlint issue in build.yml but it may be a false positive (as described in https://github.com/Homebrew/brew/pull/17482#issuecomment-2163812497):

homebrew-portable-ruby/.github/workflows/build.yml:27:16: object, array, and null values should not be evaluated in template with ${{ }} but evaluating the value of type {image: string; options: string} [expression]
   |
27 |     container: ${{matrix.container}}
   |                ^~~~~~~~~~~~~~~~~~~~~

Related to https://github.com/Homebrew/brew/pull/17482