search

Homebrew / install

📥 Homebrew (un)installer
https://brew.sh
BSD 2-Clause "Simplified" License
2.15k stars 1.02k forks source link

Don't checkout Homebrew/brew `master` for non-developers #829

Closed Bo98 closed 6 months ago

Bo98 commented 9 months ago

Currently we check out master when cloning Homebrew/brew: https://github.com/Homebrew/install/blob/3d2b88baf18424b561766fcdac31be06553e0e07/install.sh#L933

brew update will correct this to be on a stable tag, but picking master initially is not ideal because it means brew update will perform a downgrade and we don't test downgrades (but will accept fixes where there are issues). An example of an issue caused by a downgrade is #825.

Instead, short of a full stable-branch setup that brew update does, an initial detached tag checkout would be much better. Detached tag checkouts without a stable branch now work without downgrades since https://github.com/Homebrew/brew/commit/2a02038690db452b71c26d5beb9d1f07b068cacf.

MikeMcQuaid commented 9 months ago

Agreed, thanks @Bo98!

MikeMcQuaid commented 6 months ago

Fixed by https://github.com/Homebrew/install/pull/839