search

Homebrew / legacy-homebrew

💀 The former home of Homebrew/homebrew (deprecated)
https://brew.sh
26.97k stars 11.34k forks source link

Refactor code for linking meta files #10141

Closed adamv closed 12 years ago

adamv commented 12 years ago

https://github.com/mxcl/homebrew/blob/master/Library/Homebrew/build.rb#L75

The code to find meta files should be extracted out from here. It would be useful to be able to trigger this early in formula installs, especially when installing Java stuff to libexec, but wanting to put the meta files in the prefix as normal.

jacknagel commented 12 years ago

Possibly it could just run immediately before install, though that would mean the README would be missing in debug installs, for instance...

adamv commented 12 years ago

New code for this: https://github.com/adamv/homebrew/compare/metafiles

TODO - always take a Pathname instead of a string?

adamv commented 12 years ago

Ping @jacknagel @mxcl please review when you get a chance.

mxcl commented 12 years ago

Could you put it in a pull request so I can comment on lines?

adamv commented 12 years ago

Closing in favor of the pull request.