Homebrew / legacy-homebrew

💀 The former home of Homebrew/homebrew (deprecated)
https://brew.sh
26.96k stars 11.34k forks source link

pan newsreader installation fails #14336

Closed psm8888 closed 12 years ago

psm8888 commented 12 years ago

Hello

brew install -v pan https://gist.github.com/3414490

brew doctor https://gist.github.com/3414494

config.log https://gist.github.com/3414552

The obvious compile error is

CXX gui.o CXX pan.o gui.cc: In member function ‘void pan::GUI::set_queue_size_label(unsigned int, unsigned int)’: gui.cc:2232: error: no matching function for call to ‘pan::Queue::get_stats(gulong&, gulong&, gulong&, guint64&, double&, int&, int&, int&)’ ../../pan/tasks/queue.h:158: note: candidates are: void pan::Queue::get_stats(long unsigned int&, long unsigned int&, long unsigned int&, uint64_t&, double&, int&, int&, int&) make[2]: * [gui.o] Error 1 make[2]: * Waiting for unfinished jobs.... make[1]: * [install-recursive] Error 1 make: * [install-recursive] Error 1 config.log was copied to /Users/msapm1/Library/Logs/Homebrew ==> Exit Status: 2

I wonder if this relates to the recent change you made to pan in

https://github.com/mxcl/homebrew/commit/4ce190f4f43f84fd6aedce455adec57079341e6a

...which seems to remove some lines from gui.cc relating to queue.get_stats() ?

Thanks Paul

jacknagel commented 12 years ago

The upstream bug was marked resolved and the patch failed to apply, so I assumed it was fixed upstream; it builds fine for me on 10.6 at least. I suppose a new upstream bug report will be necessary, and an updated patch.

adamv commented 12 years ago

Version 1.39 and 1.38 fail to compile for me on Snow Leopard / Xcode 3.2.6.

Note that this formula also has an ENV.x11 that needs to be fixed.

jacknagel commented 12 years ago

Looks like upstream did have a fix in place, but it was reverted in favor of "doing it automatically on os x", although that hasn't happened yet. Patch incoming.

jacknagel commented 12 years ago

Someone test this please: https://github.com/jacknagel/homebrew/commit/8860b650a21f5946c5a2eace9c90b1de21243cb1

adamv commented 12 years ago

Compiled on Lion/4.2

psm8888 commented 12 years ago

Many thanks all. Also now compiles for me on 10.6.8, so also closed from my POV. Cheers! Paul