Closed ajrams closed 11 years ago
I am having this same issue (10.8.2, same failure)
I thought this patch: https://gist.github.com/raw/4278425/e7b6807a74068f2c0303ca216b74156cf1ab3a61/homebrew_john_1082.patch would fix it, but don't know enough about how to apply a patch to a patch.... any pointers: (the following just fails the patch process (hunk failed), even though it was created against the source of the jumbo patch)
diff --git a/Library/Formula/john.rb b/Library/Formula/john.rb
index eef4e8a..a81d4c9 100644
--- a/Library/Formula/john.rb
+++ b/Library/Formula/john.rb
@@ -14,6 +14,7 @@ class John < Formula
def patches
p = [DATA] # Taken from MacPorts, tells john where to find runtime files
p << "http://www.openwall.com/john/g/john-1.7.9-jumbo-7.diff.gz" if build.include? 'jumbo'
+ p << "https://gist.github.com/raw/4278425/e7b6807a74068f2c0303ca216b74156cf1ab3a61/homebrew_john_1082.patch" if build.include? 'jumbo'
return p
end
Also, it really is irksome that homebrew -d does NOT break on patch failures - is there any other way to keep the files around long enough to debug what is going on???
We really need to improve error reporting w.r.t. patches; has this been reported upstream?
simply removing "CC=#{ENV.cc}" from the line
system "make", "clean", "macosx-x86-#{arch}", "CC=#{ENV.cc}"
seems to do the trick
Reproduces on Lion / Xcode 4.5
I'm still getting the same issue on 10.9.1, using homebrew 0.9.5
:+1: me too
https://gist.github.com/4167120