search

Homebrew / legacy-homebrew

💀 The former home of Homebrew/homebrew (deprecated)
https://brew.sh
26.96k stars 11.34k forks source link

Add RFC 2047 patch to mutt.rb #20107

Closed celadevra closed 11 years ago

celadevra commented 11 years ago

RFC 2047 is an obsoleted standard for MIME Message Header Extensions for Non-ASCII Text. In most modern e-mail clients including mutt, it is substituted by RFC 2231. On mutt, if one sends an attachment with (say) Chinese filename, the receiver using obsolete clients, such as Outlook Express and Foxmail, will not see the attachment.

However, when using mutt, I have to send attachments with non-ASCII filenames to stubborn colleagues who doesn't have to know anything about RFCs. They just keep asking "Where is your attachment?". A solution was provided by http://www.emaillab.org/mutt/1.5.10/patch-1.5.10.tt.create_rfc2047_params.1.gz but the patch as-is breaks build, so I manually edited the code and generated a new patch:

https://gist.github.com/celadevra/5660812

And added two lines to the mutt.rb formula, see

https://gist.github.com/celadevra/5660898

I hope this solves problem for some users. If the formula can be updated to supply option to use this patch, I will be very grateful.

gvarisco commented 11 years ago

I'd like to see this implemented as well.

MikeMcQuaid commented 11 years ago

Have you tried to submit this to Mutt upstream?

celadevra commented 11 years ago

I think the decision that whether the patch should be incorporated by mutt is the patch's author, Takashi Takizawa, and other mutt developers'. I'll write to Takashi to see if he's interested to submit a ticket for the patch.

MikeMcQuaid commented 11 years ago

This is the type of thing that, if it's committed/accepted upstream we're happy to include but otherwise we aren't.

adamv commented 11 years ago

Closing; suggest submitting this upstream.