search

Homebrew / legacy-homebrew

💀 The former home of Homebrew/homebrew (deprecated)
https://brew.sh
26.99k stars 11.36k forks source link

brew install srtp does not create the /usr/local/lib/pkgconfig/libsrtp.pc file #42173

Closed ibc closed 9 years ago

ibc commented 9 years ago

By running brew install srtp the corresponding pkgconfig file is not created.

Within the libsrtp sources, running ./configure does create libsrtp.pc from the existing libsrtp.pc.in, and running make install copies it to /usr/local/lib/pkgconfig/. And it seems that brew install srtp calls both but the pkgconfig file is not created/copied.

https://github.com/Homebrew/homebrew/blob/master/Library/Formula/srtp.rb

In the other side, brew install libuv does copy the pkgconfig file (note that it is done during the autoconf stuff):

https://github.com/Homebrew/homebrew/blob/master/Library/Formula/libuv.rb

tdsmith commented 9 years ago

srtp only installs the .pc file if pkg-config is present at build time and the formula did not declare a dependency on pkg-config. Fixed by feec2ce. Thanks for reporting!

ibc commented 9 years ago

:cake:

ibc commented 9 years ago

Sorry... brew update && brew install srtp does not yet install libsrtp with the commit above, is that normal?

tdsmith commented 9 years ago

I realized after you posted your cake that I forgot to update the bottle; that was done in 80a76f6, so it should work if you give it another spin.

ibc commented 9 years ago

It works. Thanks!