search

Homebrew / legacy-homebrew

💀 The former home of Homebrew/homebrew (deprecated)
https://brew.sh
26.97k stars 11.34k forks source link

fastd tests are not working #50652

Closed apjanke closed 8 years ago

apjanke commented 8 years ago

Testing fastd is not working for me locally or on the test bot. Caused test failures for libsodium in homebrew/homebrew-core#10, and will probably do the same for its other dependencies.

The test is to just run fastd. When I install and brew test it locally on 10.9.5, fastd just segfaults. Maybe because tuntap requires manual intervention as root to install, as described in its caveats, and I didn't do that. And I don't think we'd do that on the test bots.

When I do a make install on 10.11, it complains about not having a secret key configured.

$ fastd
2016-04-03 02:33:34 -0400 --- Error: no secret key configured

It would be nice if this test ran. If it doesn't, maybe we should just remove the test so it doesn't bork tests for its dependents.

We could probably make this work by just having tuntap be :optional instead of :recommended, and doing fastd --version as the test.

xu-cheng commented 8 years ago

You probably want to submit formulae related issues to core tap next time.

MoritzFago commented 8 years ago

First of all, tuntap is mission critical for fastd, fastd is a (fast and secure) tunneling daemon and needs tuntap absolutely. For the problem with the test: it worked on my machine ;), but i improved the test with the last formula update. Now it at least tests a little bit of the real functionality of fastd, similar to the test in the openvpn formula.

apjanke commented 8 years ago

Okay, I can see the test passing on that formula update. I'll pull that in and see how things work out.

apjanke commented 8 years ago

New test fixed it. Thanks.