Please upgrade to KDE 4.6.2

[BrazilianJoe]

Hi,

I hope you forgive me for filing a bug on a formula which does not exists yet. I am requesting the formula to be updated, and also reporting the point to which I progressed and got stuck.

I have tried editing the kdelibs formula and updating the link and checksum for version 4.6.2.

I have also removed the patches, since, to my understanding, they were already merged upstream.

When trying to install, I get an error when the building process fails to find png.h, although ENV.x11 is being called on the formula.

[ 93%] Building CXX object khtml/CMakeFiles/khtml.dir/imload/decoders/jpegloader.o [ 93%] Building CXX object khtml/CMakeFiles/khtml.dir/imload/decoders/pngloader.o /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:30:17: error: png.h: No such file or directory /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:46: error: ‘png_structp’ does not name a type /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:47: error: ‘png_infop’ does not name a type /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:54: error: ‘png_uint_32’ does not name a type /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:55: error: ‘png_uint_32’ does not name a type /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:64: error: ‘png_structp’ has not been declared /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:64: error: ‘png_infop’ has not been declared /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:69: error: ‘png_structp’ has not been declared /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:69: error: ‘png_bytep’ has not been declared /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:69: error: ‘png_uint_32’ has not been declared /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:74: error: ‘png_structp’ has not been declared /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:74: error: ‘pnginfop’ has not been declared /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp: In static member function ‘static void khtmlImLoad::PNGLoader::dispHaveRow(int, int, int, int)’: /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:71: error: invalid conversion from ‘int’ to ‘unsigned char’ /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:71: error: initializing argument 3 of ‘void khtmlImLoad::PNGLoader::haveRow(unsigned int, int, unsigned char_)’ /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp: In member function ‘void khtmlImLoad::PNGLoader::haveInfo()’: /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:86: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:86: error: ‘pngInfoStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:86: error: ‘width’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:86: error: ‘height’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:87: error: ‘png_get_IHDR’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:97: error: ‘png_set_gray_1_2_4_to_8’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:103: error: ‘png_set_strip_16’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:109: error: ‘PNG_INFO_tRNS’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:109: error: ‘png_get_valid’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:111: error: ‘png_set_tRNS_to_alpha’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:114: error: ‘PNG_COLOR_TYPE_RGB’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:115: error: ‘PNG_COLOR_TYPE_RGB_ALPHA’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:116: error: ‘PNG_COLOR_TYPE_GRAY’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:117: error: ‘PNG_COLOR_TYPE_GRAY_ALPHA’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:125: error: ‘PNG_COLOR_TYPE_GRAY’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:128: error: ‘PNG_COLOR_TYPE_GRAY_ALPHA’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:130: error: ‘png_set_gray_to_rgb’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:133: error: ‘PNG_COLOR_TYPE_PALETTE’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:138: error: ‘png_set_palette_to_rgb’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:140: error: ‘PNG_COLOR_TYPE_RGB’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:143: error: ‘PNG_COLOR_TYPE_RGB_ALPHA’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:162: error: ‘PNG_FILLER_AFTER’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:162: error: ‘png_set_filler’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:163: error: ‘png_set_bgr’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:171: error: ‘png_set_bgr’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:179: error: ‘PNG_INTERLACE_NONE’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:183: error: ‘png_set_interlace_handling’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:193: error: ‘png_read_update_info’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:194: error: ‘png_start_readimage’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp: In member function ‘void khtmlImLoad::PNGLoader::haveRow(unsigned int, int, unsigned char)’: /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:201: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:203: error: ‘png_progressive_combine_row’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp: In constructor ‘khtmlImLoad::PNGLoader::PNGLoader()’: /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:226: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:226: error: ‘PNG_LIBPNG_VER_STRING’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:226: error: ‘png_create_read_struct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:228: error: ‘pngInfoStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:228: error: ‘png_create_info_struct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:231: error: ‘png_set_progressive_read_fn’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp: In destructor ‘virtual khtmlImLoad::PNGLoader::~PNGLoader()’: /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:238: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:238: error: ‘pngInfoStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:238: error: ‘png_destroy_readstruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp: In member function ‘virtual int khtmlImLoad::PNGLoader::processData(uchar, int)’: /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:252: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:252: error: ‘png_jmpbuf’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:252: error: ‘setjmp’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:261: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:261: error: ‘pngInfoStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.2-2euS/kdelibs-4.6.2/khtml/imload/decoders/pngloader.cpp:261: error: ‘png_process_data’ was not declared in this scope make[2]: * [khtml/CMakeFiles/khtml.dir/imload/decoders/pngloader.o] Error 1 make[2]: * Waiting for unfinished jobs.... make[1]: * [khtml/CMakeFiles/khtml.dir/all] Error 2 make: * [all] Error 2 ==> Exit Status: 2 http://github.com/mxcl/homebrew/blob/master/Library/Formula/kdelibs.rb#L39 ==> Environment HOMEBREW_VERSION: 0.8 HEAD: 0706780d2b799ad13cb42b44e45a384413ae9bc0 HOMEBREW_PREFIX: /usr/local HOMEBREW_CELLAR: /usr/local/Cellar HOMEBREW_REPOSITORY: /usr/local HOMEBREW_LIBRARY_PATH: /usr/local/Library/Homebrew Hardware: quad-core 64-bit arrandale OS X: 10.6.7 Kernel Architecture: i386 Ruby: 1.8.7-174 /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby Xcode: 4.0 GCC-4.0: N/A GCC-4.2: build 5666 LLVM: build 2335 MacPorts or Fink? false X11 installed? true ==> Build Flags CC: /usr/bin/cc => /usr/llvm-gcc-4.2/bin/llvm-gcc-4.2 CXX: /usr/bin/c++ => /usr/bin/c++-4.2 LD: /usr/bin/cc => /usr/llvm-gcc-4.2/bin/llvm-gcc-4.2 CFLAGS: -O3 -w -pipe CXXFLAGS: -O3 -w -pipe CPPFLAGS: -I/usr/local/Cellar/gettext/0.18.1.1/include -I/usr/X11R6/include LDFLAGS: -L/usr/local/Cellar/gettext/0.18.1.1/lib -L/usr/X11R6/lib MAKEFLAGS: -j4 PKG_CONFIG_PATH: /usr/local/Cellar/gettext/0.18.1.1/lib/pkgconfig

[ghost]

May I suggest that you add depends_on 'libpng' to the list of dependencies.

Just as a test.

[MikeMcQuaid]

No, it doesn't need to depend on 'libpng', that's included with X11 so we're removing it from brew. Do you have X11 installed properly? Do you get this with the current version of KDElibs?

[ghost]

OK :) Just read png.h, so I just thought I would suggest it. Good to know it's already bundled.

[BrazilianJoe]

Yes, I have X11 installed. I have tried starting e.g. dia (homebrew version) and it worked fine.

[BrazilianJoe]

I have also tried installing kdelibs 4.6.0 and it also failed. Not sure if it would matter, but I only have Xcode 4 installed. ls'ing /usr/X11R6/include shows:

drwxr-xr-x 13 root wheel 442 Mar 28 06:55 . drwxr-xr-x 8 root wheel 272 Jun 7 2010 .. drwxr-xr-x 33 root wheel 1122 Mar 28 06:55 GL drwxr-xr-x 90 root wheel 3060 Mar 28 06:55 X11 drwxr-xr-x 12 root wheel 408 Mar 28 06:55 cairo drwxr-xr-x 5 root wheel 170 Mar 28 06:55 fontconfig drwxr-xr-x 3 root wheel 102 Oct 24 2010 freetype2 -rw-r--r-- 1 root wheel 3890 Oct 24 2010 ft2build.h drwxr-xr-x 4 root wheel 136 Mar 28 06:55 libpng12 drwxr-xr-x 4 root wheel 136 Mar 28 06:55 pixman-1 lrwxr-xr-x 1 root wheel 14 Mar 28 06:48 png.h -> libpng12/png.h lrwxr-xr-x 1 root wheel 18 Mar 28 06:48 pngconf.h -> libpng12/pngconf.h drwxr-xr-x 41 root wheel 1394 Mar 28 06:55 xcb

and 'ls -la /usr/X11R6/include/libpng12/' :

drwxr-xr-x 4 root wheel 136 Mar 28 06:55 . drwxr-xr-x 13 root wheel 442 Mar 28 06:55 .. -rw-r--r-- 1 root wheel 159848 Oct 24 2010 png.h -rw-r--r-- 1 root wheel 49634 Oct 24 2010 pngconf.h

Files seem to be OK, permissions seem to be right. I cat'ed through the files, they were readable and I saw no evidence of text corruption.

[BrazilianJoe]

failure with 4.6.0:

/tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:30:17: error: png.h: No such file or directory /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:46: error: ‘png_structp’ does not name a type /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:47: error: ‘png_infop’ does not name a type /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:54: error: ‘png_uint_32’ does not name a type /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:55: error: ‘png_uint_32’ does not name a type /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:64: error: ‘png_structp’ has not been declared /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:64: error: ‘png_infop’ has not been declared /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:69: error: ‘png_structp’ has not been declared /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:69: error: ‘png_bytep’ has not been declared /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:69: error: ‘png_uint_32’ has not been declared /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:74: error: ‘png_structp’ has not been declared /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:74: error: ‘pnginfop’ has not been declared /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp: In static member function ‘static void khtmlImLoad::PNGLoader::dispHaveRow(int, int, int, int)’: /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:71: error: invalid conversion from ‘int’ to ‘unsigned char’ /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:71: error: initializing argument 3 of ‘void khtmlImLoad::PNGLoader::haveRow(unsigned int, int, unsigned char_)’ /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp: In member function ‘void khtmlImLoad::PNGLoader::haveInfo()’: /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:86: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:86: error: ‘pngInfoStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:86: error: ‘width’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:86: error: ‘height’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:87: error: ‘png_get_IHDR’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:97: error: ‘png_set_gray_1_2_4_to_8’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:103: error: ‘png_set_strip_16’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:109: error: ‘PNG_INFO_tRNS’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:109: error: ‘png_get_valid’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:111: error: ‘png_set_tRNS_to_alpha’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:114: error: ‘PNG_COLOR_TYPE_RGB’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:115: error: ‘PNG_COLOR_TYPE_RGB_ALPHA’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:116: error: ‘PNG_COLOR_TYPE_GRAY’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:117: error: ‘PNG_COLOR_TYPE_GRAY_ALPHA’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:125: error: ‘PNG_COLOR_TYPE_GRAY’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:128: error: ‘PNG_COLOR_TYPE_GRAY_ALPHA’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:130: error: ‘png_set_gray_to_rgb’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:133: error: ‘PNG_COLOR_TYPE_PALETTE’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:138: error: ‘png_set_palette_to_rgb’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:140: error: ‘PNG_COLOR_TYPE_RGB’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:143: error: ‘PNG_COLOR_TYPE_RGB_ALPHA’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:162: error: ‘PNG_FILLER_AFTER’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:162: error: ‘png_set_filler’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:163: error: ‘png_set_bgr’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:171: error: ‘png_set_bgr’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:179: error: ‘PNG_INTERLACE_NONE’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:183: error: ‘png_set_interlace_handling’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:193: error: ‘png_read_update_info’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:194: error: ‘png_start_readimage’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp: In member function ‘void khtmlImLoad::PNGLoader::haveRow(unsigned int, int, unsigned char)’: /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:201: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:203: error: ‘png_progressive_combine_row’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp: In constructor ‘khtmlImLoad::PNGLoader::PNGLoader()’: /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:226: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:226: error: ‘PNG_LIBPNG_VER_STRING’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:226: error: ‘png_create_read_struct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:228: error: ‘pngInfoStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:228: error: ‘png_create_info_struct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:231: error: ‘png_set_progressive_read_fn’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp: In destructor ‘virtual khtmlImLoad::PNGLoader::~PNGLoader()’: /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:238: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:238: error: ‘pngInfoStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:238: error: ‘png_destroy_readstruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp: In member function ‘virtual int khtmlImLoad::PNGLoader::processData(uchar, int)’: /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:252: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:252: error: ‘png_jmpbuf’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:252: error: ‘setjmp’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:261: error: ‘pngReadStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:261: error: ‘pngInfoStruct’ was not declared in this scope /tmp/homebrew-kdelibs-4.6.0-NEhl/kdelibs-4.6.0/khtml/imload/decoders/pngloader.cpp:261: error: ‘png_process_data’ was not declared in this scope make[2]: * [khtml/CMakeFiles/khtml.dir/imload/decoders/pngloader.o] Error 1 make[2]: * Waiting for unfinished jobs.... make[1]: * [khtml/CMakeFiles/khtml.dir/all] Error 2 make: * [all] Error 2 ==> Exit Status: 2 http://github.com/mxcl/homebrew/blob/master/Library/Formula/kdelibs.rb#L39 ==> Environment HOMEBREW_VERSION: 0.8 HEAD: fb69cc8fe8070514a44b0d1b760edbfb6772c261 HOMEBREW_PREFIX: /usr/local HOMEBREW_CELLAR: /usr/local/Cellar HOMEBREW_REPOSITORY: /usr/local HOMEBREW_LIBRARY_PATH: /usr/local/Library/Homebrew Hardware: quad-core 64-bit arrandale OS X: 10.6.7 Kernel Architecture: i386 Ruby: 1.8.7-174 /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby Xcode: 4.0 GCC-4.0: N/A GCC-4.2: build 5666 LLVM: build 2335 MacPorts or Fink? false X11 installed? true ==> Build Flags CC: /usr/bin/cc => /usr/llvm-gcc-4.2/bin/llvm-gcc-4.2 CXX: /usr/bin/c++ => /usr/bin/c++-4.2 LD: /usr/bin/cc => /usr/llvm-gcc-4.2/bin/llvm-gcc-4.2 CFLAGS: -O3 -w -pipe CXXFLAGS: -O3 -w -pipe CPPFLAGS: -I/usr/local/Cellar/gettext/0.18.1.1/include -I/usr/X11/include LDFLAGS: -L/usr/local/Cellar/gettext/0.18.1.1/lib -L/usr/X11/lib MAKEFLAGS: -j4 PKG_CONFIG_PATH: /usr/local/Cellar/gettext/0.18.1.1/lib/pkgconfig

Error: Failed executing: make install Please report this bug: https://github.com/mxcl/homebrew/wiki/new-issue These existing issues may help you: https://github.com/mxcl/homebrew/issues/#issue/2624 https://github.com/mxcl/homebrew/issues/#issue/5219

[MikeMcQuaid]

Did you install X11 with OSX?

[BrazilianJoe]

yes, for sure.

[MikeMcQuaid]

Can you install anything else that depends on libpng from X11?

[BrazilianJoe]

I have wine installed, it uses env.X11 in its formula.

Since wine was already installed, I uninstalled it and reinstalled. I have done a quick test by running 'wine notepad' and the program ran successfully.

I believe it uses libpng from X11 amongst other things, but I am not sure. If wine uses other stuff from X11 but not libpng, i would appreciate if you can point me to a homebrew app which needs libpng, I will be happy to test it.

[MikeMcQuaid]

grep -lri libpng `brew --prefix`/Library/Formula/

will list them for you, let me know how you get on.

[BrazilianJoe]

OK, I tried installing qrencode, which encodes strings of text into a QR code image.

I have encoded the url https://github.com/mxcl/homebrew/issues/5219 into a QR code, which I posted here: https://github.com/BrazilianJoe/images/blob/master/5219.png

It worked without problems.

[MikeMcQuaid]

Strange that it doesn't work with kdelibs then. Hmm. Will try and take another look at it some time. Can you try installing it one more time?

[BrazilianJoe]

I am reinstalling all deps listed with 'brew deps kdelibs' just to be sure.

I had the following message:

Warning: m4 macros were installed to "share/aclocal". Homebrew does not append "/usr/local/share/aclocal" to "/usr/share/aclocal/dirlist". If an autoconf script you use requires these m4 macros, you'll need to add this path manually.

On installation of the packages: libiconv, intltool, pkg-config. Since they are listed as dependencies, it wouldn't hurt to check whether these macros are necessary for kdelibs itself, or if it is causing any problem with one of the dependencies, which in turn could be exposed on the kdelibs failure.

I am still on the deps process, will post again once I try to reinstall kdelibs package again.

[MikeMcQuaid]

No, they shouldn't be necessary and wouldn't cause this problem.

[BrazilianJoe]

no progress, it still bailed out by not finding png.h

Would patching up line 30 of khtml/imload/decoders/pngloader.cpp from

include <png.h>

to

include "/usr/X11/include/png.h"

Be overly crude and ugly? Yes, but would it possibly, maybe work?

[MikeMcQuaid]

The correct solution is pass that directory as an -I CFLAG. instead.

[BrazilianJoe]

Oops, sorry for the formatting, I never learned the markdown markup.

[BrazilianJoe]

The 'right way', if there is one, for the CFLAG is to have it on the formula or system wide?

[MikeMcQuaid]

Try in the formula.

[BrazilianJoe]

I am not versed in Ruby syntax, neither an expert on Formulas. If you can help me on how to do it, I will be glad.

Otherwise, my googling trying to find how to do it pointed me to Homebrew's ENV.rb, and the 'x11' section which appends the paths to the environment seems very straightforward, I could try changing that instead, since it does not append to CFLAGS.

What do you think?

[MikeMcQuaid]

I'll try and have a look.

[BrazilianJoe]

I have changed ENV.rb to have the x11 section as follows:

def x11 opoo "You do not have X11 installed, this formula may not build." if not MacOS.x11_installed?

# There are some config scripts (e.g. freetype) here that should go in the path
prepend 'PATH', '/usr/X11/bin', ':'
# CPPFLAGS are the C-PreProcessor flags, *not* C++!
append 'CPPFLAGS', '-I/usr/X11/include'
append 'CFLAGS', '-I/usr/X11/include'
append 'LDFLAGS', '-L/usr/X11/lib'
# CMake ignores the variables above
append 'CMAKE_PREFIX_PATH', '/usr/X11', ':'

end

But the error persisted. My guesstimation is that Cmake is doing some pathfinding magic which is losing the default include paths some way along the compilation, and needs some extra prodding to cooperate.

I then did the fugly hack of changing the source code to point to the absolute path of png.h, and kdelibs was built successfully! It's certainly a kludgy workaround, but at least it compiled and installed without complaints.

I am now attempting to build kdebase-runtime to check if kdelibs is in working condition.

[MikeMcQuaid]

What is your full png header path? Can you gist your full, failing output again? Thanks.

[BrazilianJoe]

The full path is /usr/X11/include/libpng12/png.h

but there is a link to it at:

/usr/X11/include/png.h

install log:

https://gist.github.com/964428

[MikeMcQuaid]

Can I get the full install log rather than just the end? Still nothing obvious jumping out here I'm afraid.

[BrazilianJoe]

Is that what you need?

https://gist.github.com/968348

[MikeMcQuaid]

That's it. Still no idea I'm afraid, please try and file it upstream.

[adamv]

People being affected here:

Do a brew update, gist your brew doctor and do brew install -vd <foo> and gist the cmakelists.txt files in the /tmp folder.

This will help us eliminate or identify Homebrew itself as a problem here, but I suspect these issues will have to go upstream to KDE itself.