search

Homebrew / legacy-homebrew

💀 The former home of Homebrew/homebrew (deprecated)
https://brew.sh
26.96k stars 11.34k forks source link

brew doctor fails to warn about volumes #8579

Closed erikswanson closed 11 years ago

erikswanson commented 12 years ago

While attempting to install git, I encountered the exact same issue as bugs #4113 and #1238:

==> Downloading http://git-core.googlecode.com/files/git-htmldocs-1.7.7.3.tar.gz
File already downloaded in /Users/erik/Library/Caches/Homebrew
/usr/bin/tar xf /Users/erik/Library/Caches/Homebrew/git-htmldocs-1.7.7.3.tar.gz
mv: cannot resolve index.html: /private/tmp/homebrew-__UNKNOWN__-1.7.7.3-75eo/git.html
Error: 
erik@Avatar ~ $

My brew doctor output does not warn about the need to set HOMEBREW_TEMP: https://gist.github.com/1363317

As an alternative to fixing the logic in brew doctor, is there a reason why HOMEBREW_TEMP can't have a smarter default that prevents this from being an issue?

Sharpie commented 12 years ago

As an alternative to fixing the logic in brew doctor, is there a reason why HOMEBREW_TEMP can't have a smarter default that prevents this from being an issue?

I don't know of any smarter default than a location that has been officially blessed by the OS for holding temporary files. Definitely open to suggestions though.

adamv commented 12 years ago

I would like to see your volume listing to see why the brew doctor check doesn't catch this.

erikswanson commented 12 years ago

Brew lives in ~/.homebrew, and ~ is a filevault (OS X 10.6).

erik@Avatar ~ $ which brew
/Users/erik/.homebrew/bin/brew
erik@Avatar ~ $ mount
/dev/disk0s2 on / (hfs, local, journaled)
devfs on /dev (devfs, local, nobrowse)
map -hosts on /net (autofs, nosuid, automounted, nobrowse)
map auto_home on /home (autofs, automounted, nobrowse)
/dev/disk0s3 on /Volumes/Avatar-7 (ntfs, local, read-only, noowners)
/dev/disk1s2 on /Users/erik (hfs, local, nodev, nosuid, journaled, nobrowse)
/dev/disk2s2 on /Library/Encrypted Caches/Polipo (hfs, local, nodev, nosuid, nobrowse, mounted by erik)
curiosity:/export/shared/erik on /Users/erik/mnt/curiosity (osxfusefs, nodev, nosuid, synchronous, mounted by erik)
cakemix:/home/erik on /Users/erik/mnt/cakemix (osxfusefs, nodev, nosuid, synchronous, mounted by erik)
MikeMcQuaid commented 11 years ago

Does this still happen? Perhaps I'm being stupid but I'm not sure I see the bug here?

erikswanson commented 11 years ago

I'm using Filevault 2 now, so the original reason for me to be have homebrew on a separate filesystem from the default tempdir no longer applies.

It looks like #14710 could have fixed the underlying issue that 'brew doctor' was failing to warn me about, but I have not tested this.