search

HomecareHomebase / azure-bake

An Open Source Deployment Management Framework for DevOps and Developers
MIT License
9 stars 14 forks source link

Feature/az mon unified diag settings traffic mgr #87

Closed bdschaap closed 5 years ago

bdschaap commented 5 years ago

Configures diagnostic settings for Traffic Manager ingredient

JasonPagel commented 5 years ago

The "if" check for whether or not to use diagnostics should use "===" instead of "==". Also consider using "true" / "false" with the parameters on the recipe instead of "yes" / "no" for consistency.

bdschaap commented 5 years ago

The "if" check for whether or not to use diagnostics should use "===" instead of "==". Also consider using "true" / "false" with the parameters on the recipe instead of "yes" / "no" for consistency. I just tested out bool for Bake params again and it works so I'll change it and stop using string for this. I'll change to ===.