HomecareHomebase / azure-bake

An Open Source Deployment Management Framework for DevOps and Developers
MIT License
9 stars 14 forks source link

Azure VM Ingredient #91

Closed csperbeck closed 5 years ago

csperbeck commented 5 years ago

Azure VM Ingredient creates a windows or linux vm based on the options selected, and stands up either the selected vm. For optimal usage, you would pair with the Network Interface and Storage Ingredients. Please review @whilke @JasonPagel @jasonshamilton

csperbeck commented 5 years ago

Committed fixed and updated the ingredient to removed the osType parameter from the templates, and remove the parameter from the bakeParams before it is submitted for deployment.

csperbeck commented 5 years ago
[Tue, 02 Jul 2019 22:36:34 GMT] East US Baking recipe windows-test
[Tue, 02 Jul 2019 22:36:34 GMT] East US : windows-test Azure VM Plugin Logging:
[Tue, 02 Jul 2019 22:36:34 GMT] East US : windows-test adding ingredient type[@azbake/ingredient-azure-vm] source[]
[Tue, 02 Jul 2019 22:36:34 GMT] East US : windows-test validating deployment...
[Tue, 02 Jul 2019 22:36:35 GMT] East US : windows-test starting deployment...
[Tue, 02 Jul 2019 22:38:38 GMT] East US : windows-test deployment finished...
whilke commented 5 years ago

Committed fixed and updated the ingredient to removed the osType parameter from the templates, and remove the parameter from the bakeParams before it is submitted for deployment.

Looks like you just need to resolve a conflict with the event-hub ingredient?

csperbeck commented 5 years ago

@whilke the main bake build is failing because there is a non UTF-8 character in that package.json. Will figure out how to get it resolved

csperbeck commented 5 years ago

Have to exclude the checkout on PR... one sec

whilke commented 5 years ago

@whilke the main bake build is failing because there is a non UTF-8 character in that package.json. Will figure out how to get it resolved

If your branch has the fixed version I can just force the merge through to correct it