search

Honatas / bootstrap-4-autocomplete

A simple autocomplete/typeahead for Bootstrap 4 and jQuery
MIT License
56 stars 31 forks source link

Multi word search #19

Open troyd1000 opened 3 years ago

troyd1000 commented 3 years ago

One thing it seems no one has and that is also with jquery autocomplete is multi word search. Say in your example, if I do bo au ex, it would find anything matching all those words. It is a nice way to whittle down a list matching multiple things. I made updates to your JS to do this. Feel free to implement them to your core if you like.

attached is the updated file. ac.zip

Honatas commented 3 years ago

@troyd1000 thanks for the time spent with this enhancement, but I'm afraid this is not the correct way to contribute. Opening a zip file is risky, therefore I'm not doing it. If you wish to contribute, please fork the project, add your code and then create a pull request, please.

troyd1000 commented 3 years ago

Jonatas, sorry, all I have ever done with github is download code and did not know how that worked. I think I worked through adding a fork, updating the code and adding a pull request. Let me know if it worked.

Honatas commented 3 years ago

It did work!! =)

I'll take a look at it and run some tests as soon as possible.

Honatas commented 3 years ago

@troyd1000 , you have modified the wrong file, the transpiled javascript file. You have to modify the Typescript file.

troyd1000 commented 3 years ago

I don’t know how to do typescript and don’t have the time to figure it out right now. If you wish to interpret what I did and add it to your project feel free. Otherwise, you can just let it go. I have spent a lot of time on figuring out updating things on github and don’t have time to do more.

Honatas commented 3 years ago

Ok, no problem. And thanks again!

I'll keep this issue open in case anyone wants to pick up from where you left.