Honestpuck / scriptorium

A utility for managing the scripts in Jamf Pro
MIT License
52 stars 6 forks source link

Crash if /usr/local/var/log/ does not exist #1

Closed joeselway closed 3 years ago

joeselway commented 3 years ago

Works fine after manually creating dir ➜ Scriptorium scriptorium down Traceback (most recent call last): File "/Users/joe/bin/scriptorium", line 750, in <module> Scripts.main() File "/Users/joe/bin/scriptorium", line 714, in main Scripts.setup_logging() File "/Users/joe/bin/scriptorium", line 277, in setup_logging ch = logging.handlers.TimedRotatingFileHandler( File "/usr/local/Cellar/python@3.9/3.9.4/Frameworks/Python.framework/Versions/3.9/lib/python3.9/logging/handlers.py", line 208, in __init__ BaseRotatingHandler.__init__(self, filename, 'a', encoding=encoding, File "/usr/local/Cellar/python@3.9/3.9.4/Frameworks/Python.framework/Versions/3.9/lib/python3.9/logging/handlers.py", line 58, in __init__ logging.FileHandler.__init__(self, filename, mode=mode, File "/usr/local/Cellar/python@3.9/3.9.4/Frameworks/Python.framework/Versions/3.9/lib/python3.9/logging/__init__.py", line 1146, in __init__ StreamHandler.__init__(self, self._open()) File "/usr/local/Cellar/python@3.9/3.9.4/Frameworks/Python.framework/Versions/3.9/lib/python3.9/logging/__init__.py", line 1175, in _open return open(self.baseFilename, self.mode, encoding=self.encoding, FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/var/log/scriptorium.log'

Honestpuck commented 3 years ago

Fixed with commit 3a38594. It now checks and if /usr/local/var/log doesn't exist it calls os.makedirs(/usr/local/var/log)