Hong-Kong-Districts-Info / hktrafficcollisions

Shiny app dashboard of HK traffic collisions that result in injury. | 香港車禍傷亡資料庫：利用互動地圖和儀表版，將香港車禍位置和相關數據可視化。

Other

8 stars 2 forks source link

Feat: Add link to Google Street View in popup #81

Closed KHwong12 closed 2 years ago

KHwong12 commented 2 years ago

Summary

This branch adds link to Google Street View in popup.

Changes

The changes made in this PR are:

Adds a link to Google Street View in the popup of the collision, which is in the format of
```
https://maps.google.com/?cbll=latitude,longitude&cbp=0,bearing,0,zoom,tilt
```

When users click on the link, a new tab showing the street view will be opened.

https://user-images.githubusercontent.com/29334677/189707872-ad7afff9-7d12-4a9d-bf81-7addfe90de44.mp4

Check

[x] (If UI & data are updated) The UI & data includes Traditional Chinese translation, with translation terms wrapped in i18n$t() and terms added to translation_zh.csv
[x] The travis.ci and R CMD checks pass.

Note

Known issues of going to street view by only providing longitude and latitude:

Cannot distinguish whether location is in ground level/flyover/underground
When there is no street view available for the location of the collision point, the link will look for the nearest community-contributed panorama