search

HongPong / broken-link-checker

This plugin will check your posts, comments and other content for broken links and missing images, and notify you if any are found. (non-commercial community fork of broken-link-checker)
10 stars 4 forks source link

question regarding version vs. official version #42

Closed atomGit closed 4 years ago

atomGit commented 4 years ago

i went to install the latest version from this repo but i see in WP that i have 1.11.8 installed and this repo is 1.11.7, yet the code here was updated after .8

can someone help me understand?

HongPong commented 4 years ago

@atomGit hi, this is not packaged with the version number currently. It's a fork, not a continuation, so really the old numbers don't apply. (and from my view it seems like it doesn't make sense to simply increment the number. maybe something like 1.11.8-fork-1 makes more sense?)

Earlier I had proposed potentially submitting this as a different plugin altogether later this year, but that would entail changing more of the code.

In any case the company managing the plugin has not posted any updates. I am aiming to look and see what other patches people have made on other forks but haven't done so yet - been tied up on other projects.

atomGit commented 4 years ago

thanks for clearing that up

and thanks again for maintaining the project

i assume the youtube API key has not been updated in your code from what i understand? that's fine, i can do that manually

HongPong commented 4 years ago

I have not gone into the YouTube stuff but if you have found a workable patch a PR would be welcome, thanks :)

On Sat, Jul 27, 2019, 7:29 AM atomGit notifications@github.com wrote:

thanks for clearing that up

and thanks again for maintaining the project

i assume the youtube API key has not been updated in your code from what i understand? that's fine, i can do that manually

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HongPong/broken-link-checker/issues/42?email_source=notifications&email_token=AAA3227WQFVM2WDSVIS6RXDQBQWQ7A5CNFSM4IHHD2W2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD26JXOQ#issuecomment-515677114, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA322ZMC72FF6O26L6JYJ3QBQWQ7ANCNFSM4IHHD2WQ .