search

HongRay / pe

0 stars 0 forks source link

When editing deadline 31st February entry was accepted. #11

Open HongRay opened 5 months ago

HongRay commented 5 months ago

image.png

Steps to reproduce: Enter command: edit o/1 by/31/2/1999

Expected: Error message that says such date does not exist.

Actual: Automatically assumed that the deadline is 28/2/1999 instead.

nus-pe-bot commented 5 months ago

Team's Response

Duplicate issue that shares the same concerns as #5165

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Trying to change the order deadline to a non-existent date doesn't give a warning, gives different date as well

If i try to edit the deadline to a non-existent date like 29/02/2025, it doesn't give an error. Instead it changes the deadline to 28/02/2025. Unexpected behaviour that could cause confusion.

Screenshot 2024-04-19 at 16.48.30.png

Screenshot 2024-04-19 at 16.48.46.png

The deadline has changed to 28/02/2025 instead.

Screenshot 2024-04-19 at 16.48.53.png

[original: nus-cs2103-AY2324S2/pe-interim#4859] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This was intentional, as in the rare case where users think it is a leap year and want to set the date to 29th February even though its a non existent date, we allow them to do so as we are implying that they mean that the order is to be completed at the end of the month. If the date were to be lets say 32/02/2024. The program will return an error, the only times it allows the user to input a date with the day up till 31, as we imagine the user still wants the order to be created for a date towards the end of the month. If they later find out when the deadline is near that they needed an extra 1 or 2 days to fulfill the order, they can simply postpone the deadline by editing it using the edit command. Hence we feel that the issue should be of severity low, as it rarely affects the users workflow when using the app.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]