HongRay / pe

0 stars 0 forks source link

Complete order allowed for orders in stage 1 #13

Open HongRay opened 2 months ago

HongRay commented 2 months ago

Steps to reproduce: Enter complete 2 where 2 is an order stage is in stage 1.

Expected: Error message that says order is only in stage 1.

Actual: Order was completed and removed.

This causes problems as the command might be entered by accident and thus losing the entire order details for the employer/employee.

nus-pe-bot commented 2 months ago

Team's Response

This is the intended effect as the stage command is mainly to give users the option to mark the orders with the status. We wanted to give users more freedom by which they need not use the stage command in their business process and are able to just use the complete command whenever they fulfil an order. In essence, stage command is just a cosmetic feature that helps users keep a note on the stage of the order and complete command is a functional command that transfers the order details into a csv file for archiving.

In fact, using complete command will not result in the employee losing the entire order details as they are still able to see the order ID, Product name, Product quantity, cost, sales and profit in the completedOrders.csv file which is part of the business process

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: If this was an intended outcome, then it would be a Documentation Flaw instead. This should have been specified in the UG as a warning that the complete command works with orders in stage 1, preventing confusion.

Due to the hindsight that this is a Documentation Flaw I agree that this is of Low severity instead of High but I disagree that this isn't a bug.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]