nus-se-bot
commented
5 months ago Team's Response
This bug is due to the inherent nature of files in general. Generally, for All Files, when you open them with a editting software while a program is depending on it and trying to edit it, it is a no-go. It is out of our hands to change how files work. The purpose of complete command is to allow users to at the end of the day, have a csv file to check the past orders.
We can possibly fix these in the future by creating a new csv file each time a command is ran, but it would clutter the users files.
The reason why the error message is shown but the command when through was because cancel command does not alter the state of the csv file, but when it tried to check for new completed orders, it detected that you had it running in an excel program.
In fact, the error message thrown is not incorrect as having the excel open while running commands is a current issue that the program is facing. The message gave you a potential fix by closing the file being opened by another process. thus, it is not entirely incorrect.
Items for the Tester to Verify
:question: Issue response
Team chose [response.NotInScope]
- [x] I disagree
Reason for disagreement: While the error message does provide a potential fix, it could be misinterpreted as being linked directly to the actions of the cancel command rather than the complete command which checks for new completed orders. This can be confusing, especially since the cancel command itself does not alter the CSV file.
I believe that this is an issue as the execution of the cancel command produced an "error behaviour" (error message + command line text turned red and command line text did not clear) even when the command of cancel went through. If the behaviour was what is explained, I believe a Warning message should have been displayed without the "error behaviour" (error message + command line text turned red and command line text did not clear).
Since the command of cancel was successful even though an error message and error behaviour were produced, I stand firm that this is a bug within scope.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** With my explanation above, I believe that the severity should stay the same. In fact, even if it was documented in the UG, it still does not justify the corresponding incorrect "**error** behaviour" and successful `cancel` command execution.
Steps to reproduce:
Expected: Cancel order without success message.
Actual: An error message of
Could not save data due to the following error: data\completedorders.csv (The process cannot access the file because it is being used by another process)was shown even though the order in the UI is already removed.