Hoodineee / pe

0 stars 0 forks source link

Duplicate itinerary is allowed if description is capitalised #7

Open Hoodineee opened 1 year ago

Hoodineee commented 1 year ago

image.png

Duplicate itinerary is allowed if one description is in lower case while the other is in upper case. Might be an issue for fast typers.

nus-pe-bot commented 1 year ago

Team's Response

Same design decision as mentioned in Issue #4522.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

The itinerary is not case sensitive

I am able to add 2 trips to Singapore with the exact same details. This should be considered as a duplicated plan

Screenshot 2022-11-11 at 4.24.24 PM.png


[original: nus-cs2103-AY2223S1/pe-interim#4630] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is a design decision where we only check the description of the itinerary to see if it is a same plan. We have also decided to make this check case-sensitive. Additionally, this does not cause any inconvenience to the user.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Without knowing which itinerary is being used to plan the trip might results in them using both itinerary to plan their trip. This might cause their itinerary to be jumbled between 2 different plans which would inconvenience the user. Although rare, this could be a possibility and I think checking for duplicates of other fields in the itinerary could prove to be useful to users.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]