Hoohm / dropSeqPipe

A SingleCell RNASeq pre-processing snakemake workflow
Creative Commons Attribution Share Alike 4.0 International
147 stars 47 forks source link

Resolve issue with vioplot #91

Closed TomKellyGenetics closed 5 years ago

TomKellyGenetics commented 5 years ago

Resolves #83 and #84

I encountered a similar issue. The input to the vioplot rule is an absolute path so getwd() is not needed.

Dependency on Rcpp added for devtools as fs required by usethis: https://github.com/r-lib/fs/issues/90#issuecomment-498500264

TomKellyGenetics commented 5 years ago

I think this also resolves #89 as I had a similar error message.

seb-mueller commented 5 years ago

Thanks for catching this. We've tried to fix this for a while now, but for some reason this has never made it into the repository: https://github.com/seb-mueller/dropSeqPipe/commit/7a537ec83aeee045631fa7608ffb157cf932bcfd

Having said that, I'm much in favor to resolve it for good and merge this PR. Any objection @Hoohm ?