Hooverdan96 / HDHR-DVR-docker

Docker Wrapper for SiliconDust's HDHomeRun DVR Record Engine
https://hub.docker.com/r/jackdock96/hdh_dvr
MIT License
0 stars 1 forks source link

multi-platform/architecture version of docker container #5

Closed Hooverdan96 closed 1 year ago

Hooverdan96 commented 3 years ago

gotta figure that out somehow

Hooverdan96 commented 3 years ago

can't get buildx to work for some reason. The other approaches all seem somewhat convoluted (additional manifest to display all architectures on the docker hub as one pull, etc.) but might have to dig in to figure out ...

Hooverdan96 commented 3 years ago

keeping it open

Hooverdan96 commented 3 years ago

pushed multi-architecture version to docker hub finally using (with Docker Desktop):

docker buildx build --platform linux/amd64,linux/arm64,linux/arm/v7 -t 'jackdock96/hdh_dvr:latest' --push .

from within locally cloned repository. Platform tag based on this:

https://github.com/containerd/containerd/blob/master/platforms/platforms.go#L63

Important, that files (especially sh scripts) are formatted with Unix linebreaks (build will still work, but entrypoint script will fail)!

Hooverdan96 commented 3 years ago

Now need somebody to test on arm device, since I don't have any available.

Hooverdan96 commented 1 year ago

Thanks to NolanT for proposing the GitHub action approach. Merged now. Also built a new action file for publishing to current docker hub instance.