Hopding / pdf-lib

Create and modify PDF documents in any JavaScript environment
https://pdf-lib.js.org
MIT License
6.74k stars 645 forks source link

Updated yarn add in README.md #1500

Closed s0h311 closed 9 months ago

s0h311 commented 1 year ago

What?

updated the installation command for yarn.

Why?

For dev dependency it should be yarn add -D and not just yarn add

How?

Testing?

New Dependencies?

Screenshots

Suggested Reading?

Anything Else?

Checklist

thm76 commented 9 months ago

I think this needs to be more nuanced because in some cases you will need to install pdf-lib as a dependency (I'm generating PDFs inside a React App) but in other cases it's a devDependency - I have another app where I'm generating PDFs at build time only.

In my opinion I would leave it as is, no "-D" flag. This is also consistent with the npm install command.

If the "-D" flag should be added then add it to npm install as well.