Double check on the backwards compatibility of hosp parameter names in config

HopkinsIDD / COVIDScenarioPipeline

Public shared code for doing scenario forecasting and creating reports for various governmental entities.

GNU General Public License v3.0

104 stars 47 forks source link

Double check on the backwards compatibility of hosp parameter names in config #161

Open eclee25 opened 4 years ago

eclee25 commented 4 years ago

refers to update after age-standardization was added as an option for hosp calculations time_hosp_death versus time_death parameters in config?

kgrantz commented 4 years ago

Old configs used time_death for time from hospitalization to death. Going forward, time_hosp_death is the preferred specification when running non-age standardized functions (in order to separate from time_onset_death, which is required for age standardized calculations). But, when run_age_adjusted: FALSE or run_age_adjusted: NULL, time_death is used in place of time_hosp_death if time_hosp_death is not specified to ensure compatibility

jkamins7 commented 4 years ago

can you write test cases to make sure this is working?