Closed TimothyWillard closed 2 weeks ago
No need to review yet, still WIP per the suggestions above.
Above comments have been address and this PR is ready for review again now.
@saraloo, @emprzy, or @pearsonca is there any chance we could get this review and merged soon?
This PR:
gempyor.parameters
module and its only classParameters
,Parameters
class,gempyor.parameters
using the__all__
dunder`.This PR does not:
list
/dict
types not being fully specified),parameters_reduce
method of theParameters
class.This is the first in one or two more PRs to address GH-276. I didn't implement any tests for
parameters_reduce
yet because I still need to get a handle on theNPI
objects. However, I think it would be best to get this first pass done to set ground for the next pass.