search

HopkinsIDD / globaltoolbox

1 stars 0 forks source link

fix redundant database variables: "depth_from_source" and "level" #53

Closed shauntruelove closed 4 years ago

shauntruelove commented 5 years ago

These appear to be redundant. For some locations, level is NA. Remove level? Or maybe rename "depth_from_source" as "level", as that seems like the more intuitive name.

shauntruelove commented 5 years ago

Let's set the levels to mirror standard administrative levels: Country = 0 States, Provinces, Districts, etc. = 1 Departments, Counties, etc. = 2 ...

shauntruelove commented 5 years ago

This defines the levels clearly: https://sedac.ciesin.columbia.edu/povmap/ds_defs_admin.jsp

jkamins7 commented 5 years ago

sorry, depth from source is specifically how far down the tree one needs to traverse from the source (defaults to the tree root) in order to get to the result. not sure what level is. where does it appear?

shauntruelove commented 5 years ago

maybe we should have an admin_level variable too that reflects the accepted admin level standards? the "level" column appears in my df after getting the full db with "get_location_metadata()". Check "R-in-dev/testing_and_exploring.R" to quickly see all of these issues.