search

HopkinsIDD / globaltoolbox

1 stars 0 forks source link

Fix locations with same readable_name #55

Open shauntruelove opened 5 years ago

shauntruelove commented 5 years ago

"togo" and "::japan::aichi::togo" both have "togo" as a readable_name, meaning searching the db will match both (and thus none).

Part of the problem is removing encoding (::japan::aichi::togo has lots of accents). But otherwise not sure how to fix this. Maybe record it as "togo, japan"? But then it might have trouble if someone is matching within Japan, though this would be remedied once it searches aliases (where "togo" could remain).

jkamins7 commented 5 years ago

fix for this: just use depth in this case as well. i think in general we want to allow things to exist in the database with the same readable name. i think i might have code already written for this. ping me tomorrow if i don't close this with a commit