search

Hopson97 / Empire

A cellular automaton I made up myself, written in C++/ SFML
MIT License
147 stars 31 forks source link

Fix macOS #16

Closed ghost closed 6 years ago

ghost commented 6 years ago

This PR fix some bugs on macOS:

  1. TextColour doesn't work on macOS and result to this error: use of undeclared identifier 'TextColour'

Is this work on other OS ?

  1. CMake Error at CMakeLists.txt:27: Parse error. Expected a command name, got unquoted argument with text "?".

Maybe this "?" was usefull on other OS ?

  1. Missing "#include " in ColonyStatistics.cpp: implicit instantiation of undefined template 'std::1::basic_ostringstream<char, std::__1::char_traits, std::1::allocator >' std::ostringstream stream; ^ Should I include sstream for all OS ?
Hopson97 commented 6 years ago

Thanks!

  1. I use Windows, so I had to rely on someone else for the UNIX colours, but I am not sure how Mac OS does this.

  2. That may have been a typo. I don't use CMake myself (As I just use an IDE), but rather other people who make pull requests do.

  3. And if that fixes the issue, then sure :p

Hopson97 commented 6 years ago

For the console colour thing, I'd rather there be an file with empty defitions for the functions and enums (so that someone may be able to fix that) rather than polluting the code with

ifndef APPLE

everywhere

dctucker commented 6 years ago

The fix could be far simpler than this. Please see my comments on issue #18