search

Hopson97 / Empire

A cellular automaton I made up myself, written in C++/ SFML
MIT License
147 stars 30 forks source link

Added wider unix color compatibility with VT100 16-bit colors #5

Closed Spartan322 closed 7 years ago

Spartan322 commented 7 years ago

Changed grid of people from vector simulating a grid to a more grid like object Adjusted .gitignore to disregard compiled file changes Adjusted the CMakeLists.txt thread reference to correspond to Threads::Threads Added Default value to TextColour enum (also saving the first default attribute scheme on windows)

Hopson97 commented 7 years ago

I like your changes, they will increase readability :) (as well as work on Unix for the colours which is always nice)

One thing I am confused about is line 210 on World.cpp, you call "Grid::init" but I see no "init" function in the Grid class when looking at the changed files. Was this accidentally removed?

Thanks for the interest in my project though :)

Spartan322 commented 7 years ago

The init is in reference to the Person object contained within the grid.

Hopson97 commented 7 years ago

Oh right! I feel silly now.

Looks good to pull!

Hopson97 commented 7 years ago

I mean merge.

Thanks!