[Amiberry 3.0.2] please read first

HoraceAndTheSpider / Amiberry-XML-Builder

Python script to scan LHA files for WHDLoad integration in Amiberry

13 stars 3 forks source link

[Amiberry 3.0.2] please read first #46

Closed nemo93 closed 4 years ago

nemo93 commented 4 years ago

Well the new 3.0.2 update seems to behave differently than 3.0... As such the modifications submitted for the screen height are not valid any longer. At least for most of them. Also this new release fix speed issue in games already submitted (no need to set FAST_COPPER=TRUE any longer for Agony, Brian Lion, James Pond 3, etc).

I suggest to wait a bit before pushing all the changes. I need to ask a thing or 2 to @midwan to be sure and prior doing further testing.

Sorry for that :-(

midwan commented 4 years ago

Sorry about that, due to a bug found in the "smart centering" function, I had to disable it by default. It's still there, and I will add GUI controls to enable it on demand (like WinUAE), but the default is off. This changes the centering behavior a bit from v3.0.

nemo93 commented 4 years ago

Hi @midwan please don't be sorry! To me the most important is compatibility and from that regard Amiberry does a hell of a job!! To have this "smart centering" would be nice to have though. Do you mind me asking the following about this future function:

if enabled can I assume I'll have same behavior as on 3.0? So that I can continue with my testing and submit changes here? I'll specify wait for "future release prior pushing".
please confirm this function won't revert/change the FAST_COPPER setting as noted above? I understood this parameter is a sort of hack hence I prefer to keep it disabled as it works nicely now (even for Jim Power \o/).
would you recommend me to keep on pushing with my testing with the current 3.0.2? Or should I wait or revert to 3.0 or something?

Thanks again for what you do. Let me be sorry for raising so many tickets at once.

midwan commented 4 years ago

@nemo93 1) Yes, enabling this will do the same thing as in v3.0. Banshee had an issue with the horizontal centering there, the vertical centering seemed to be fine but I disabled both of them by default to keep it consistent with WinUAE. 2) It's not related to Fast Copper in any way. 3) I'd recommend we always move forward, unless we run into a bug and we have to revert (in which case, we'll have a new version still)

nemo93 commented 4 years ago

Thanks I do confirm it works great. I'm commenting some tickets and keep on with my testing. Thanks!