search

HoraceAndTheSpider / Amiberry-XML-Builder

Python script to scan LHA files for WHDLoad integration in Amiberry
13 stars 3 forks source link

Ninja Remix, Last Ninja 2 and Last Ninja 3 #74

Closed darkglobe closed 4 years ago

darkglobe commented 4 years ago

Following on from my controls enhancements a few days ago, I have experimented with screen sizes and I think those I have proposed in the 3 pull requests work best. BUT...

For Ninja 2 and 3, the change clips a couple of lines of pixels that add nothing to the game in exchange for making the overall gameplay area larger and a better fit for a better gaming experience from RetroPie but...

That's on my system and my version of the game. It's probably the same version everyone has but I wish I could be 100% sure. I also wish I knew a way to make changes to the XML and test them locally in AmiBerry before I upload them to git because I have a few more complex changes I'd like to make to some other games but don't want to until I can test locally first.

Any help appreciated.

HoraceAndTheSpider commented 4 years ago

Hi

Changing the settings is just a case of adding to the text files with the subpath name.

So if , for example you want to give Last Ninja 2 a screen height of 262, you edit the Screen_Height_262.txt file and add "LastNinja2" into a new line.

You can then create a Pull request here, like you did for the custom controls and the new setting will eventually filter into the updated XML within a few days :)

As a design choice, i always say to maximise the gameplay screen, without comprimising anything in the menus/titles. (See a recent thread about Alien Breed: Tower Assault where this came up. If you want me to test out your setting, let me know what you think is ideal (i've never played the Last Ninja games)

darkglobe commented 4 years ago

Thanks

I've created pull requests for the screen size changes to the Last Ninja games that I think work best. Ninja Remix on the Amiga, a remake of the original Last Ninja on the C64, is the most faithful to the look & feel of the original games and is my favourite. Great music too.

nemo93 commented 4 years ago

hello @darkglobe :-) thanks a lot for contributing! Last Ninja(s) indeed are so great, bring back a lots of memories here!! @HoraceAndTheSpider you have to give them a try!

Regarding screen size, I second @HoraceAndTheSpider and whenever I push a change I always favor gameplay as it's the screen users will see the most. The outcome is a larger screen during game. If "authenticity" is really important I trust users can either generate a uae (save configuration) or resize the screen via Amiberry GUI. => I just altered Last Ninja games (remix, 2 & 3) few days ago. I found 200 as HEIGHT to be a good setting. Screen is almost full and the few missing pixels (I couldn't even see) are not preventing/altering the gameplay at all. I'm fine doing another round of testing is required. I checked on your repo as well and I have same feedback re Elvira Arcade and the Lotus serie of games. => @HoraceAndTheSpider has the final cut :-)

@darkglobe if that could help you as I see you've pushed PRs which modify directly the whdload_db.xml file. It would be best to follow @HoraceAndTheSpider guidance above. Please change only the files under "settings/" by adding/removing subpath from those and then create a PR based on those settings files only. => if that helps, you could look in my repo there's a "refresher" script which will regenerate the whdload file based on the settings/customcontrols files. Nice for testing :-) All credits to @HoraceAndTheSpider again as I just edited few lines from this script.

HoraceAndTheSpider commented 4 years ago

You are both welcome to chat on a Discord if you’d like to talk through anything

https://discord.gg/equ59e

nemo93 commented 4 years ago

I've added the changes from @darkglobe to the PR to simplify and to speed things up!