search

HoraceAndTheSpider / Amiberry-XML-Builder

Python script to scan LHA files for WHDLoad integration in Amiberry
13 stars 3 forks source link

Turrican 1, 2 & 3 screen height changes. #76

Closed darkglobe closed 4 years ago

darkglobe commented 4 years ago

Made the changes for all three to the XML in the same commit.

HoraceAndTheSpider commented 4 years ago

Hi @darkglobe - thanks again. I have to trust the experience of users for this project so I’m happy to merge itz

If you are making a PR there is no need to raise an issue as well. Only if there is something to discuss, and in those cases it’s better to raise just the Issue because that save you the bother of making a PR if you think there may be a change needed before it goes in!

I get notifications on email and Discord for both anyway :)

darkglobe commented 4 years ago

I noticed you said I made changes to the wrong file again...sorry can you just explain what that means please, I must have missed something.

I notice @nemo93 had the Turrican games all set one step below what I am suggesting. Could this be difference between the configs of our setups or @nemo93 leaning towards completeness of the display rather than maximised gameplay area I've gone for?

@nemo93 - can you try my Turrican sizes on your setup please and see what you think or if you lose anything important to the game? On my setup, only the title screens lose some display (that's not important or noticeable) the game itself fits very nicely.