HoraceAndTheSpider / Amiberry-XML-Builder

Python script to scan LHA files for WHDLoad integration in Amiberry
13 stars 3 forks source link

Auto Height Override #88

Closed HoraceAndTheSpider closed 3 years ago

HoraceAndTheSpider commented 4 years ago

Need to decide how auto height is going to be handled.

Possibly we don’t need to do anything to the XML builder except removing from the height lists those games which we have “comprised” on, with bits of cropping, as these may look better with manual height.

A fixed manual height is still better imho than auto height if it stays the same throughout the game.

On the Amiberry side, we should default the auto-height on, unless users has selected off or a manual, universal, height in hostprefs

midwan commented 4 years ago

If Auto-Height is enabled in Amiberry, it will override any custom height value set. So I think the best approach would be, enable auto-height in cases it works well, disable it and use a manual height value in cases it has glitches.

I don't think it should be enabled by default, considering that it's still rather experimental and there will certainly be glitches in some scenarios (don't know how many yet, but I've seen a few already).

HoraceAndTheSpider commented 4 years ago

I guess the reason i say auto-height by default (unless specifed by the user) is because @nemo93 has already put manual values to a large number of games, and at that would take priority!

I'm thinking of cases like Alien Breed Tower Assault, which crops the bottom of the menu screen, that we test it to see if auto-height works, and if so remove the 'fixed height' option.

If you have concerns about the default route, i'll just add it as a 'higher priority' in the XML instead, and we can selected it only in tested scenarios. e.g. via Screen_AutoHeight.txt here

midwan commented 4 years ago

I didn't clarify my thoughts enough. :)

I meant I don't think it should be enabled by default "out-of-the-box", but of course there can be a setting to have it "enabled by default" if the users wishes to do so. Like we have with other similar settings (auto-center for example).

nemo93 commented 3 years ago

FYI I just sent PR #97 few minutes ago.