search

HoriSun / closure-compiler

Automatically exported from code.google.com/p/closure-compiler
0 stars 0 forks source link

Log PhaseOptimizer altered source at Level.FINEST #1250

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes:
Reviewing progression of source changes after each process run

When reviewing my code changes, please focus on:
Location of logging within 'public void process(Node externs, Node root)'

Original issue reported on code.google.com by tnti...@gmail.com on 22 Feb 2014 at 4:11

Attachments:

GoogleCodeExporter commented 9 years ago 
Sample log configuration and command line call:

java -Djava.util.logging.config.file=log.properties -jar build/compiler.jar 
--logging_level=FINEST 1176.js

Original comment by tnti...@gmail.com on 22 Feb 2014 at 4:23

Attachments:

GoogleCodeExporter commented 9 years ago 
Can you sign the CLA?
https://code.google.com/p/closure-compiler/source/browse/CONTRIBUTORS

Original comment by dim...@google.com on 24 Feb 2014 at 6:54

GoogleCodeExporter commented 9 years ago 
Done electronically.

Original comment by tnti...@gmail.com on 25 Feb 2014 at 11:03

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision cab258307ef0.

Original comment by blic...@google.com on 26 Feb 2014 at 12:52

GoogleCodeExporter commented 9 years ago 
This change was actually rolled back internally (the external repo will be 
updated later), so it won't be fixed, sorry. People argued that printing the 
whole source makes sense only for very small programs, and it would obfuscate 
the output when used on large projects. So, if you want to see the source after 
every pass while debugging, you'll have to do it manually.

Original comment by dim...@google.com on 26 Feb 2014 at 12:55

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 1436a7c86ee2.

Original comment by blic...@google.com on 26 Feb 2014 at 1:07

GoogleCodeExporter commented 9 years ago

Original comment by blic...@google.com on 26 Feb 2014 at 1:10

GoogleCodeExporter commented 9 years ago 
No probs. It was the only FINEST logging in the source, but thought output 
length may be an issue.

Original comment by tnti...@gmail.com on 26 Feb 2014 at 8:49