HoriSun / closure-compiler

Automatically exported from code.google.com/p/closure-compiler
0 stars 0 forks source link

minor refactoriong in CodePrinterTest to remove duplication #1270

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes:
I'm looking at improving the pretty printer (see issue 981), but I noticed some 
duplication in CodePrinterTest parsePrint methods, so here's some simple 
refactoring to remove duplication. Ignore the import statement re-order if 
you'd like -- I use eclipse and it automatically arranges imports.

When reviewing my code changes, please focus on:

Original issue reported on code.google.com by leebreis...@gmail.com on 5 Mar 2014 at 2:08

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by tbreisac...@google.com on 5 Mar 2014 at 5:18

GoogleCodeExporter commented 9 years ago
Nick, can you help get this patch up on codereview.appspot.com so that it will 
be easier to review? It would be good to have a wiki page or something on how 
to upload patches to codereview.appspot.com anyway.

Original comment by tbreisac...@google.com on 5 Mar 2014 at 5:21

GoogleCodeExporter commented 9 years ago
For whatever reason, the Google styleguide puts com.google imports first then 
others, then java.* imports: 
http://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s3.3.3-import-o
rdering-and-spacing

Other than that, lgtm.

Original comment by tbreisac...@google.com on 5 Mar 2014 at 5:29

GoogleCodeExporter commented 9 years ago
i added a note to the contributors wiki page on how to use rietveld for 
codereview. i'll commit the patch later tonight if i have time. thanks!

Original comment by Nicholas.J.Santos on 5 Mar 2014 at 10:30

GoogleCodeExporter commented 9 years ago
I actually already committed it internally, so it should show up on git in a 
few hours. Thanks for the wiki page, I think it makes the project a lot more 
new-contributor-friendly :)

Original comment by tbreisac...@google.com on 5 Mar 2014 at 10:32

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 928bc47c8fb7.

Original comment by blic...@google.com on 7 Mar 2014 at 2:19