Closed GoogleCodeExporter closed 9 years ago
Original comment by tbreisac...@google.com
on 5 Mar 2014 at 5:18
Nick, can you help get this patch up on codereview.appspot.com so that it will
be easier to review? It would be good to have a wiki page or something on how
to upload patches to codereview.appspot.com anyway.
Original comment by tbreisac...@google.com
on 5 Mar 2014 at 5:21
For whatever reason, the Google styleguide puts com.google imports first then
others, then java.* imports:
http://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s3.3.3-import-o
rdering-and-spacing
Other than that, lgtm.
Original comment by tbreisac...@google.com
on 5 Mar 2014 at 5:29
i added a note to the contributors wiki page on how to use rietveld for
codereview. i'll commit the patch later tonight if i have time. thanks!
Original comment by Nicholas.J.Santos
on 5 Mar 2014 at 10:30
I actually already committed it internally, so it should show up on git in a
few hours. Thanks for the wiki page, I think it makes the project a lot more
new-contributor-friendly :)
Original comment by tbreisac...@google.com
on 5 Mar 2014 at 10:32
This issue was closed by revision 928bc47c8fb7.
Original comment by blic...@google.com
on 7 Mar 2014 at 2:19
Original issue reported on code.google.com by
leebreis...@gmail.com
on 5 Mar 2014 at 2:08Attachments: