HoriSun / closure-compiler

Automatically exported from code.google.com/p/closure-compiler
0 stars 0 forks source link

Would like JSCompiler to error if a comment block never ends #157

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. I wrote the following code into my .js file:

/**
 * "Resets" this view by requesting the root view.
 *
detroit.picker.CropView.prototype.reset_ = function() {
  ...
};

2. Compiled
3. Ran

What is the expected output?

Should fail to compile!  If the comment block never ends in a file, it 
should be an error.

What do you see instead?

Compiler was happy, browser was happy, up until I needed to call reset_.

What version of the product are you using? On what operating system?

Latest and greatest.

Original issue reported on code.google.com by jonemer...@google.com on 10 May 2010 at 11:04

GoogleCodeExporter commented 9 years ago
when i compile with that code, i get an "unterminated comment" error. are you 
sure?

Original comment by Nicholas.J.Santos on 11 May 2010 at 8:02

GoogleCodeExporter commented 9 years ago
Are there some flags you're using that I should enable?  I'm definitely sure 
the code 
compiled.  Maybe it's the result of another file being concatted with it before 
it was 
built, which would could have had a */ as part of the copyright notice.  Would 
JSCompiler be concatting before verification?

Original comment by jonemer...@google.com on 11 May 2010 at 11:02

GoogleCodeExporter commented 9 years ago
nope. we never concatenate files naively. 

do you have repro steps? maybe there's some other tool in your build setup 
that's 
concatenating things together?

Original comment by Nicholas.J.Santos on 11 May 2010 at 11:49

GoogleCodeExporter commented 9 years ago
since i can't repro, i'm marking as invalid. please reopen if you can come up 
with 
repro steps. i still think the problem is probably rooted in some other build 
tool 
you're using.

Original comment by Nicholas.J.Santos on 14 May 2010 at 9:37