Closed lgiussan closed 1 year ago
Okey I left unresolved the comment related to stuff that should be addressed in the monorepo. When the monorepo branch is stable let's bring the current Marlin inside it. Then we will open a PR addressing the remaining changes so we can keep track of them PS. The ToBytes deprecation was already performed by me in ginger-lib's sponge branch, so no need to address it here anymore.
Besides the requested changes, I did an additional change. At matrix construction time I re-index the columns of the matrix to be coherent with the treatment of public input domain X
as a subdomain of the domain H
. In this way there is no need to re-index matrix columns during computations.
This pull request addresses Issue #27. The high level changes are the following:
UnnormalizedBivariateLagrangePoly
is replaced with the normalizedLagrangeKernel
.LagrangeKernel
.