Mac os support for shieldedcoinbase

HorizenOfficial / zen_archived

TLS integration and more!

https://zensystem.io

Other

128 stars 44 forks source link

Mac os support for shieldedcoinbase #116

Closed pierstab closed 6 years ago

NotSoAnarchicBot commented 6 years ago

Can one of the admins verify this patch?

tarrenj commented 6 years ago

Has this been implemented in Upstream?

On Jan 24, 2018 12:40 AM, "pier" notifications@github.com wrote:

@pierstab https://github.com/pierstab requested your review on: ZencashOfficial/zen#116 https://github.com/ZencashOfficial/zen/pull/116 Mac os support for shieldedcoinbase .

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ZencashOfficial/zen/pull/116#event-1438807261, or mute the thread https://github.com/notifications/unsubscribe-auth/ADieFHohNC-pGUJnwwpMVcXwUccBc_maks5tNsJigaJpZM4RqkV4 .

pierstab commented 6 years ago

upstream doesn't support mac os directly, we are going to follow this https://github.com/ZencashOfficial/zencash/projects for the all the zencash specific code/changes

tarrenj commented 6 years ago

utACK, unable to test on OS X. Will verify normal operation on Debian later tonight...

tarrenj commented 6 years ago

Builds fine on Debian, testing now...

./qa/zen/full-test-suite.sh passes
./qa/pull-tester/rpc-tests.sh wallet_shieldcoinbase passes
./qa/pull-tester/rpc-tests.sh -extended passes with nominal unrelated failures: mempool_tx_input_limit.py, proxy_test.py, zmq_test.py

Leaving ACK as ut because I haven't been able to verify added functionality on os X. Requesting support from @cronicc and @PatrickHennis.