search

HorizenOfficial / zend_oo

This repository is archived, Zendoo is out of beta and has been included in https://github.com/HorizenOfficial/zen.
https://github.com/HorizenOfficial/zen
Other
34 stars 22 forks source link

send_certificate RPC command arguments. #114

Open VolodymyrBabaiev opened 3 years ago

VolodymyrBabaiev commented 3 years ago

There are some issues on argument processing in send_certificate RPC command:

  1. Wrong number of mandatory arguments in checking number of arguments.
  2. Wrong description of forwardTransferScFee and mainchainBackwardTransferScFee(they must be required, not optional)
  3. In WebSocket sendi certificate request forwardTransferScFee, mainchainBackwardTransferScFee and fee parameters are added to arguments in wrong orgder.
  4. WebSocket python interface(ws_proxy.py) must support new send_certificate arguments(vFieldElementCertificateField, vBitVectorCertificateField, forwardTransferScFee, mainchainBackwardTransferScFee)
  5. WebSocket python should contain cases that check new send_certificate arguments mentioned before