search

HorizenOfficial / zend_oo

This repository is archived, Zendoo is out of beta and has been included in https://github.com/HorizenOfficial/zen.
https://github.com/HorizenOfficial/zen
Other
34 stars 22 forks source link

Python tests fixes after merge. #183

Closed i-Alex closed 3 years ago

i-Alex commented 3 years ago

1) ws_messages.py works fine for me 2) sc_proof_verifier_low_priority_threads.py fixed 3) getblockmerkleroots.py ignored (was done by cronic in other branch) 4) sc_block_partitions.py fixed 5) sc_csw_eviction_from_mempool.py fixed. 6) sc_stale_ft_and_mbtr.py interfaces fixed, but seems a bug in the test flow. @alsala please take a look.

cronicc commented 3 years ago

CI run with this PR and #148 combined https://app.travis-ci.com/github/HorizenOfficial/zend_oo/builds/237104676

cronicc commented 3 years ago

@i-Alex @DanieleDiBenedetto getblockmerkleroots.py passes, but got a couple of other failures.

List of errors in CI, generally timing issues are worse on CI as performance can be unpredictable:

  1. ws_messages.py https://app.travis-ci.com/github/HorizenOfficial/zend_oo/jobs/535975332#L1965 and https://app.travis-ci.com/github/HorizenOfficial/zend_oo/jobs/535975338#L1967-L1989

    Assertion failed: Websocket performs too slow: 1.23874497414 sec. Expect to take less than 1 sec.
Stopping nodes
############ Server closed connection
##### ws client closing
Cleaning up
Failed
!!! FAIL: ws_messages.py !!!

  2. sc_stale_ft_and_mbtr.py https://app.travis-ci.com/github/HorizenOfficial/zend_oo/jobs/535975333#L840-L886 and https://app.travis-ci.com/github/HorizenOfficial/zend_oo/jobs/535975339#L865-L873

    === Running testscript sc_stale_ft_and_mbtr.py ===
File "/mnt/build/qa/rpc-tests/test_framework/test_framework.py", line 125, in main
self.run_test()
File "/mnt/build/qa/rpc-tests/sc_stale_ft_and_mbtr.py", line 334, in run_test
assert_false(txFT in bl_json['tx'])
File "/mnt/build/qa/rpc-tests/test_framework/util.py", line 439, in assert_false
assert_true(not condition, message)
File "/mnt/build/qa/rpc-tests/test_framework/util.py", line 436, in assert_true
raise AssertionError(message)

new sc_cert_getblocktemplate.py https://app.travis-ci.com/github/HorizenOfficial/zend_oo/jobs/535975333#L888-L918

=== Running testscript sc_cert_getblocktemplate.py ===
______ travis keep alive ______
  File "/mnt/build/qa/rpc-tests/test_framework/test_framework.py", line 125, in main
    self.run_test()
  File "/mnt/build/qa/rpc-tests/sc_cert_getblocktemplate.py", line 181, in run_test
    assert(len(self.nodes[i].getblocktemplate()['certificates']) == 0)
i-Alex commented 3 years ago

"ws_messages.py" and "sc_cert_getblocktemplate.py" tests were optimized for CI.

cronicc commented 3 years ago

New CI run with latest commits and #185 https://app.travis-ci.com/github/HorizenOfficial/zend_oo/builds/237185942