As we're going to default to building with bmi2/adx Rust compiler flags (which requires at least Intel Broadwell or AMD Excavator architectures) we should investigate how binaries compiled with these flags behave on platforms that don't support them.
I see two possible cases:
zend fails to start, e.g. with a segfault
zend does start, but fails when specific functions from zendoo-mc-cryptolib are being called, e.g. certificate verification
Case 1. would be "safe" for us and wanted behavior, although it would be nice to print useful information about the incompatibility to the user.
But if 2. is the case we should add code to zend to detect the incompatible platform, bail and notify the user.
As we're going to default to building with bmi2/adx Rust compiler flags (which requires at least Intel Broadwell or AMD Excavator architectures) we should investigate how binaries compiled with these flags behave on platforms that don't support them.
I see two possible cases:
Case 1. would be "safe" for us and wanted behavior, although it would be nice to print useful information about the incompatibility to the user.
But if 2. is the case we should add code to zend to detect the incompatible platform, bail and notify the user.
If we do have to modify zend_oo, compatibility to older architectures by building with
--legacy-cpushould be taken into account, see https://github.com/HorizenOfficial/zend_oo/commit/5d557abe72c8181884eea0d3be853711d45be3e2.