Adds height slider and station records from CD. Tweaks slider parameters slightly for the purposes of our fork. Also, adds custom parameters for species age min/max and appearance thresholds (i.e. "she is a young/middle-aged/old diona", etc) for adjustment in future PRs.
TODO:
[X] Port height slider
[X] Port character records
[X] Port initial records implementation + tweaks and fixes
[X] Test it and make sure nothing is horrible and broken
[ ] Figure out why the height slider snaps and fix it
[X] Check CD cryo system vs wizden and try to port records clearing
Small issues:
Height slider doesn't go all the way to 0.87 and snaps to 0.90 when saved. This seems to correlate with the character not getting any visually smaller when lowering the slider below 0.90, and snapping to heights throughout. Which is weird, because testing this on Sector Umbra neither of these things seem to happen. (...Honestly, I might just steal their code for this...)
Station records do not get unloaded when a player goes into cryo. This is because the CD PR meant to fix this (#159) applies to their own cryo system instead of wizden's implementation. I am going to look into these systems to see if I need to mess with anything (partially because, honestly, ripping out the CD cryo system just to get the build to not error out feels incredibly sloppy). I have a feeling that worst case I can just rip out all of CD's cryo logic but that also feels sloppy. Just, y'know, slightly less sloppy. Nevermind, I don't actually think we need to clear records? Upstream doesn't clear their own records when someone cryo's, so it should be fine.
About the PR
Adds height slider and station records from CD. Tweaks slider parameters slightly for the purposes of our fork. Also, adds custom parameters for species age min/max and appearance thresholds (i.e. "she is a young/middle-aged/old diona", etc) for adjustment in future PRs.
TODO:
and try to port records clearingSmall issues:
Station records do not get unloaded when a player goes into cryo. This is because the CD PR meant to fix this (#159) applies to their own cryo system instead of wizden's implementation. I am going to look into these systems to see if I need to mess with anything (partially because, honestly, ripping out the CD cryo system just to get the build to not error out feels incredibly sloppy). I have a feeling that worst case I can just rip out all of CD's cryo logic but that also feels sloppy. Just, y'know, slightly less sloppy.Nevermind, I don't actually think we need to clear records? Upstream doesn't clear their own records when someone cryo's, so it should be fine.Why / Balance
roled play
Technical details
See various CD PR's: https://github.com/cosmatic-drift-14/cosmatic-drift/pull/1 https://github.com/cosmatic-drift-14/cosmatic-drift/pull/162
https://github.com/cosmatic-drift-14/cosmatic-drift/pull/129 https://github.com/cosmatic-drift-14/cosmatic-drift/pull/152 https://github.com/cosmatic-drift-14/cosmatic-drift/pull/159 https://github.com/cosmatic-drift-14/cosmatic-drift/pull/176 https://github.com/cosmatic-drift-14/cosmatic-drift/pull/187 https://github.com/cosmatic-drift-14/cosmatic-drift/pull/205 https://github.com/cosmatic-drift-14/cosmatic-drift/pull/210
Media
Media TK
Breaking changes
Changelog