🐛[BUG][Combat] WHM job ability 'Devotion' missing 5%

HorizonFFXI / HorizonXI-Issues

Issue Tracker for HorizonXI

14 stars 1 forks source link

🐛[BUG][Combat] WHM job ability 'Devotion' missing 5% #1767

Closed SpaggiG closed 12 months ago

SpaggiG commented 12 months ago

What does this bug affect?

Currently on horizon, white mage learn devotion while leveling, in the code where it checks for merit categories it sees 0. this incurs an unintended -5% mp efficiency on use.

Steps to Reproduce

Have 1000 hp, use devotion, lose 250 hp, target only gains 200 mp

Expected behavior

Have 1000 hp, use devotion, lose 250 hp, target only gains 250 mp

Additional context

overefined commented 12 months ago

I am not sure how to test this but looking at the code I assume this should be changed to player:getMerit(xi.merit.DEVOTION) * 5