What does this bug affect?
The crit damage bonus from X's knife is interacting weirdly with the damage formula and removing damage variability from crits when attack capped.
Steps to Reproduce
Test 1:
Equip a Hoplites Harp in main hand, no offhand
Sneak attack a lv1 mob
observe a slightly variable crit damage range over attempts
in my short testing @114 DEX, 359 Atk, SA damage range was 467-487 over 20 attempts
Test 2:
Keep Hoplites Harp in main hand, equip X's knife in offhand
Sneak attack a lv1 mob
observe an increase in crit damage, but no damage variability at all between attempts
same testing as above @114 DEX, 359 Atk, SA damage was always exactly 510 over 20 attempts
Expected behavior
The results of Test 2 should have a variable damage range just like Test 1, but with an extra 10% damage increase (based this off the item_mods.sql file in ASB github listing Xs Knife as having CRIT_DMG_INCREASE: 10)
Screenshots
Hoplites Harp + No Offhand
Hoplites Harp + X's Offhand
Additional context
This same thing happens when just putting X's alone in the main hand, hitting for constant 516's with my above DEX rather than the 510 from H.Harpe (2 damage difference between weapons * 3.0 pDif to bridge that 6 damage difference maybe?)
Also seemed that all my normal melee crits hit for exactly 146 with X's mainhand, but my sample size for that was much smaller (~5 melee crits)
I also did a test of 70 Sneak attacks each using just X's mainhand, Hoplites Harp mainhand, and Hoplites Harp mainhand w/ X's in the offhand (210 SA's total), targeting lv82 merit sheep outside Tav Safehold. Here, the results ended up being more in line with the expected boost to crit damage, and all weapon combos had a damage range as expected.
What does this bug affect? The crit damage bonus from X's knife is interacting weirdly with the damage formula and removing damage variability from crits when attack capped.
Steps to Reproduce Test 1:
Test 2:
Expected behavior The results of Test 2 should have a variable damage range just like Test 1, but with an extra 10% damage increase (based this off the item_mods.sql file in ASB github listing Xs Knife as having CRIT_DMG_INCREASE: 10)
Screenshots Hoplites Harp + No Offhand
Hoplites Harp + X's Offhand
Additional context This same thing happens when just putting X's alone in the main hand, hitting for constant 516's with my above DEX rather than the 510 from H.Harpe (2 damage difference between weapons * 3.0 pDif to bridge that 6 damage difference maybe?)
Also seemed that all my normal melee crits hit for exactly 146 with X's mainhand, but my sample size for that was much smaller (~5 melee crits)
I also did a test of 70 Sneak attacks each using just X's mainhand, Hoplites Harp mainhand, and Hoplites Harp mainhand w/ X's in the offhand (210 SA's total), targeting lv82 merit sheep outside Tav Safehold. Here, the results ended up being more in line with the expected boost to crit damage, and all weapon combos had a damage range as expected.